Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share annotation image deferred menu memory leak #806

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix share annotation image deferred menu memory leak #806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Zotero/Scenes/Detail/PDF/PDFCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,8 @@ extension PDFCoordinator: PdfAnnotationsCoordinatorDelegate {
scale: CGFloat,
title: String
) -> UIDeferredMenuElement {
UIDeferredMenuElement { [weak self] elementProvider in
guard let self else {
UIDeferredMenuElement { [weak self, weak boundingBoxConverter] elementProvider in
guard let self, let boundingBoxConverter else {
elementProvider([])
return
}
Expand Down