Text and Underline annotation support

[michalrentka]

Closes #712

[mvasilak]

Code looks good so far 👌


Interesting use of keyboard accessories, we could discuss if this UX is more appropriate for other annotation types as well. There is an issue of discoverability, I get those with double tap, is that correct?


FInally, a couple of times the text annotation drawing would zoom, without me changing anything about it. I only noticed after it happened, so I don’t have any hints as to what may have caused it. Dismissing and reopening the PDF, would restore what I expected.

[michalrentka]


Interesting use of keyboard accessories, we could discuss if this UX is more appropriate for other annotation types as well.

Other annotations don't really use keyboard as their main way of editing though. For text it makes sense.

There is an issue of discoverability, I get those with double tap, is that correct?

Yes. First tap is to select and the ability to move and scale text. Second tap is to confirm we actually want to edit text or its settings.


FInally, a couple of times the text annotation drawing would zoom, without me changing anything about it. I only noticed after it happened, so I don’t have any hints as to what may have caused it. Dismissing and reopening the PDF, would restore what I expected.

I'll try to reproduce, but it might be PSPDFKit issue.

[michalrentka]

@mvasilak can you take another look at this? I updated and fixes some things, we'll be merging this with free text and underline annotations disabled in UI for the time being.

[mvasilak]

AnnotationViewController.swift is not part of the project, is it still in use?

Icons for the new types are still missing, right?

[michalrentka]

Icons for the new types are still missing, right?

Yes, I created a ticket for it #871. They won't be visible for now though.