Context pane notes list focus handling edits #4837
Conversation
- fix the issue of focus not landing on search field of the notes pane when it is opened on tab from the reader - shift-tab from the sidenav when notes pane is opened will focus the search input as well, instead of the last focusable node in the pane - tab from a note-row in the list of notes will focus the sidenav - shift-tab from a note-row will focus the header of the collapsible-section of the row Per zotero#4235 (comment)
|
This looks good, except if you're on a note row and Tab to the sidenav, and then Shift-Tab, you end up back in the note search field instead of on the note you were on before. |
|
Oh, which I guess you're saying was on purpose, but I'm not sure why? Just feels wrong. |
|
And to be clear, I'd expect it to refocus the specific element in the list that was focused before, as we do in the annotations tab of the left sidebar. |
I noticed that before this tweak, Shift-Tab would move focus back from the sidenav, which would land on the last focusable element (e.g. "X more" button at the bottom) and felt quite weird after playing around with it. So I thought that simulating a tab into the notes list (to land on the search input) would be less weird, that way focus is at least at the top. But it's a great idea to add an extra step to remember what note was last focused (just with a special attribute, maybe) and focusing that, if it exists. |
|
Yeah, I think it's pretty much just identical to the Annotations tab. You can move up/down in that list and Tab or Shift-Tab out of it, and then if you go back in, you're on the same entry. |
|
Similarly, I guess, we might want to do the same when tabbing forward in. So if you use down-arrow to move down the list, Shift-Tab back to the section header disclosure button, and Tab back, you'd end up on the same note row. This is also, of course, how the collection and item trees work. |
|
Let's get this in and tweak that separately. This is already an improvement. |
- remember the last focused note-row in the contextPane and, if possible, refocus it on shift-tab from sidenav, on tab from the reader into notes pane, or on tab into the notes list from the collapsible-section. Otherwise, focus the search input. Per: zotero#4837 (comment) - when a note is opened in the context pane, let shift-tab from sidenave place focus on the links-box. That way, it is not skipped during tab navigation. - fix focus not entering note-editor on Tab from the "Go back" button and instead wrapping around to the current tab
- remember the last focused note-row in the contextPane and, if possible, refocus it on shift-tab from sidenav, on tab from the reader into notes pane, or on tab into the notes list from the collapsible-section. Otherwise, focus the search input. Per: #4837 (comment) - when a note is opened in the context pane, let shift-tab from sidenav place focus on the links-box. That way, it is not skipped during tab navigation. - fix focus not entering note-editor on Tab from the "Go back" button and instead wrapping around to the current tab
sidenavwhen notes pane is opened will focus the search input as well, instead of the last focusable node in the pane (e.g. "X more..." button at the bottom)note-rowin the list of notes will focus thesidenavnote-rowwill focus the header of thecollapsible-section. I thought focusing the reader right away would be too much, since one might need to get to the+button to add a note, or something like that. And once you are at a section header, you can jump to the header of the previous section (if there is one) witharrowUp, at which point, you are at the top of the notes pane.Per #4235 (comment)