Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close citation dialog if user interacts with the integration plugin #4859

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adomasven
Copy link
Member

Asks the user if they want to discard the changes in their existing dialog if they have made changes.

If there is no citation dialog, but a command is running (like updating the document) an alert is displayed.

Closes #4855

@adomasven
Copy link
Member Author

I imagine there may be a better way to use fluent here, but given that the form or gender of "document preferences", "citation dialog" and "bibliography dialog" may be different in different languages and require different wording, I split them into different strings.

@dstillman
Copy link
Member

I'm getting a communication error from Word while testing this:

  1. Click Add/Edit Citation and make a selection, but don't close the dialog.
  2. Return to Word and move the cursor elsewhere in the document.
  3. Click Add/Edit Citation again.

I get the warning about changes, and then in a second or two Word starts bouncing in my dock (because of the communication-error alert). If I click Cancel — don't discard changes — and then press Return to accept my changes, the progress dialog just hangs, because Word is stuck in the background with the communication-error alert.

Asks the user if they want to discard the changes in their existing dialog if
they have made changes.

If there is no citation dialog, but a command is running (like updating the document)
an alert is displayed.

Closes zotero#4855
@adomasven adomasven force-pushed the alert-on-repeat-integration-commands branch from 8d11169 to 7356ede Compare December 3, 2024 08:00
@adomasven
Copy link
Member Author

adomasven commented Dec 3, 2024

Fixed. Mac Word HTTP communication has some caveats that other plugins don't which is why this was failing. Should be fine on all platforms now.

Also rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Close citation dialog if user interacts with the integration plugin
2 participants