Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for copy/paste of MVS files within and cross lpars #3387
Support for copy/paste of MVS files within and cross lpars #3387
Changes from 16 commits
d666151
93724b4
8246e26
07fd0b0
d56402a
a02d3db
b9f5cb4
5236966
34397b3
9775a4b
00e21da
8eb8f21
ce768bf
d8edfaa
739ad19
16ee193
2b59528
7196577
caa20f9
668a35e
c226f16
a4f7447
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove this check, we are already going to call the _getSession and replacing the "existing one"
is that desired, or will that cause some breakage in certain edge cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the check is in place, in the function
copyDataSetCrossLpar
after generating thesourceSession
with the help ofthis.getSession(sourceprofile)
the targetSession will also be generated same as sourceSession with the callthis.getSession()
which is not the case when u want to paste the copied dataset to different LPAR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the source dataset is not cataloged? It would seem that ZE won't be able to find it in order to perform the copy operation 😢
On the other hand, if we do not want to support uncataloged datasets, we should probably not even specify
volume: undefined
. Given that volume is also optional inIOptions
, why not just pass an empty object instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have made it to send an empty object {}
Check warning on line 306 in packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts
Codecov / codecov/patch
packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts#L306
Check warning on line 310 in packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts
Codecov / codecov/patch
packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts#L310
Check warning on line 312 in packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts
Codecov / codecov/patch
packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts#L312
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What can we expect with an extender that works with this on day 1 and a user tries but their extension wasn't updated like we see the zFTP extension? Should a check be done in ZE making this statement like we do for other new APIs/functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JillieBeanSim Removed it from ftp as the ZE functionality already has the check in place for it.