-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for copy/paste of MVS files within and cross lpars #3387
Changes from 17 commits
d666151
93724b4
8246e26
07fd0b0
d56402a
a02d3db
b9f5cb4
5236966
34397b3
9775a4b
00e21da
8eb8f21
ce768bf
d8edfaa
739ad19
16ee193
2b59528
7196577
caa20f9
668a35e
c226f16
a4f7447
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -303,6 +303,15 @@ | |
throw new ZoweFtpExtensionError("Copy dataset is not supported in ftp extension."); | ||
} | ||
|
||
public copyDataSetCrossLpar( | ||
zFernand0 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
toDataSetName: string, | ||
toMemberName: string, | ||
options: zosfiles.ICrossLparCopyDatasetOptions, | ||
sourceprofile: imperative.IProfileLoaded | ||
): Promise<zosfiles.IZosFilesResponse> { | ||
throw new ZoweFtpExtensionError("Copy dataset cross lpar is not supported in ftp extension."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What can we expect with an extender that works with this on day 1 and a user tries but their extension wasn't updated like we see the zFTP extension? Should a check be done in ZE making this statement like we do for other new APIs/functionality? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @JillieBeanSim Removed it from ftp as the ZE functionality already has the check in place for it. |
||
} | ||
|
||
public async renameDataSet(currentDataSetName: string, newDataSetName: string): Promise<zosfiles.IZosFilesResponse> { | ||
const result = this.getDefaultResponse(); | ||
let connection; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove this check, we are already going to call the _getSession and replacing the "existing one"
is that desired, or will that cause some breakage in certain edge cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the check is in place, in the function
copyDataSetCrossLpar
after generating thesourceSession
with the help ofthis.getSession(sourceprofile)
the targetSession will also be generated same as sourceSession with the callthis.getSession()
which is not the case when u want to paste the copied dataset to different LPAR.