Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Centos6/7 compilation issues #469

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Fix for Centos6/7 compilation issues #469

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f80b662
Fix for Centos6/7 compilation issues
greenozon Mar 8, 2024
28fdb90
Prefer the parameters be renamed and this warning (-Wshadow) kept to …
greenozon Mar 11, 2024
6bae7e6
Fix unhappy MSVC compiler on special toekens
greenozon Mar 11, 2024
ce439a6
Return back -Wshadow compiler option into non-Windows envs
greenozon Mar 11, 2024
68a697d
Revert "Fix for Centos6/7 compilation issues"
greenozon Mar 12, 2024
ba91ff2
Revert shadow changes and add option -Wno-error=shadow to cmakefile
greenozon Mar 12, 2024
fd80a35
Restore changes for shadow warnings...
greenozon Mar 12, 2024
8367a8e
Return back a fix for Centos6/7 compilation issues not related to sha…
greenozon Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ASTNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ void ASTNodeList::removeLast()

void ASTNodeList::removeFirst()
{
m_nodes.erase(m_nodes.cbegin());
m_nodes.erase(m_nodes.begin());
}


Expand Down
2 changes: 1 addition & 1 deletion ASTree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ static bool printClassDocstring = true;
// shortcut for all top/pop calls
static PycRef<ASTNode> StackPopTop(FastStack& stack)
{
const auto node{ stack.top() };
const auto node(stack.top());
stack.pop();
return node;
}
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ if (ENABLE_STACK_DEBUG)
endif()

if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
set(CMAKE_CXX_FLAGS "-Wall -Wextra -Wshadow -Werror ${CMAKE_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS "-Wall -Wextra -Werror ${CMAKE_CXX_FLAGS}")
greenozon marked this conversation as resolved.
Show resolved Hide resolved
elseif(MSVC)
set(CMAKE_CXX_FLAGS "/WX ${CMAKE_CXX_FLAGS}")
add_definitions(-D_CRT_SECURE_NO_WARNINGS)
Expand Down
Loading