Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegesis scan for quietest channel #1010

Merged

Conversation

triller-telekom
Copy link
Contributor

Fixes #1009

Signed-off-by: Stefan Triller [email protected]

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #1010 into master will decrease coverage by 0.01%.
The diff coverage is 6.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1010      +/-   ##
============================================
- Coverage     30.36%   30.34%   -0.02%     
+ Complexity     4050     4048       -2     
============================================
  Files          1425     1425              
  Lines         55277    55303      +26     
  Branches       2449     2454       +5     
============================================
- Hits          16785    16783       -2     
- Misses        37759    37785      +26     
- Partials        733      735       +2     
Impacted Files Coverage Δ Complexity Δ
...zigbee/dongle/telegesis/ZigBeeDongleTelegesis.java 20.04% <0.00%> (-1.21%) 19.00 <0.00> (ø)
.../internal/protocol/TelegesisActiveScanCommand.java 91.42% <ø> (ø) 8.00 <0.00> (ø)
.../internal/protocol/TelegesisEnergyScanCommand.java 94.87% <66.66%> (ø) 8.00 <0.00> (ø)
...ems/zigbee/transaction/ZigBeeTransactionQueue.java 92.50% <0.00%> (-1.25%) 25.00% <0.00%> (-1.00%)
...s/zigbee/transaction/ZigBeeTransactionManager.java 93.92% <0.00%> (-0.41%) 69.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73355bb...6173cdc. Read the comment docs.

@cdjackson
Copy link
Member

Do you need to run the autocoder as well? It seems you've made the change, but not updated the classes?

@triller-telekom
Copy link
Contributor Author

I did run the autocoder but it turned out only TelegesisActiveScanCommand.java and TelegesisEnergyScanCommand.java were affected by the internal class that I have made public now.

@cdjackson
Copy link
Member

Thanks Stefan.

@cdjackson cdjackson merged commit 15a3c63 into zsmartsystems:master Mar 21, 2020
@triller-telekom triller-telekom deleted the telegesisQuietestChannel branch March 23, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telegesis scan for quietest channel
2 participants