Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified to support Weblogic JMX #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

juhgiyo
Copy link

@juhgiyo juhgiyo commented Feb 12, 2015

Thank you for providing such a great module.

While I was trying to use your module for Weblogic Server MBeans with JMX using t3 protocol, I fount that it must use different protocolProvider, and some of libraries from Oracle.

I'm not sure if this change is against your philosophy, but I decided to do a pull request for the reference to someone, who might have same problem as me.

Again, thanks a lot for providing a great module.

@zuazo
Copy link
Owner

zuazo commented Feb 16, 2015

Hi @juhgiyo,

Wow! thanks for your PR, I'm really interested in merging it 😃

But I think it would be good to improve some issues before:

  • Fix coverage: tests are missing (See the coveralls report).
  • Duplicated code: I think the waiting logic should be refactored to its own function. MBeanServerConnection#connect function is getting too big.
  • I'm not sure about this, do you think including wlclient.jar (472KB) in the module is a good idea? Maybe we can document that is required to download it manually.

It's OK if you do not have time for this now. I'll leave this PR open whatever time it takes.

When Bean was not created, handle null object exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants