Use integer 0 instead of character \0 in memset().

zufuliu · Jan 22, 2025 · 0589943 · 0589943
1 parent 55f90c8
commit 0589943
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/scintilla/lexers/LexHTML.cxx b/scintilla/lexers/LexHTML.cxx
@@ -187,7 +187,7 @@ bool isHTMLCustomElement(const char *tag, size_t length, bool dashColon) noexcep
 
 int classifyTagHTML(Sci_PositionU end, LexerWordList keywordLists, LexAccessor &styler, bool &tagDontFold, bool isXml, bool allowScripts) {
 	char s[63 + 1];
-	memset(s, '\0', 4);
+	memset(s, 0, 4);
 	const Sci_PositionU start = styler.GetStartSegment();
 	styler.GetRange(start, end, s, sizeof(s));
 	char *tag = s;

diff --git a/scintilla/lexers/LexPHP.cxx b/scintilla/lexers/LexPHP.cxx
@@ -225,7 +225,7 @@ void PHPLexer::ClassifyHtmlTag(LexerWordList keywordLists) {
 		sc.SetState((tagType == HtmlTagType::Question) ? SCE_H_QUESTION : SCE_H_TAG);
 	} else if (tagType == HtmlTagType::None) {
 		char s[16];
-		memset(s, '\0', 4);
+		memset(s, 0, 4);
 		sc.GetCurrentLowered(s, sizeof(s));
 		const char *p = s + 1;
 		if (StrEqual(p, "script")) {

diff --git a/scintilla/lexers/LexVB.cxx b/scintilla/lexers/LexVB.cxx
@@ -503,7 +503,7 @@ void FoldVBDoc(Sci_PositionU startPos, Sci_Position lengthDoc, int initStyle, Le
 	int ifThenMask = 0; // If ... Then ... End If
 	int wordLen = 0;
 	char s[MaxKeywordSize];
-	memset(s, 4, 4);
+	memset(s, 0, 4);
 
 	while (startPos < endPos) {
 		const int style = initStyle;

diff --git a/scintilla/lexlib/LexAccessor.cxx b/scintilla/lexlib/LexAccessor.cxx
@@ -39,7 +39,7 @@ bool LexAccessor::MatchLowerCase(Sci_Position pos, const char *s) noexcept {
 void LexAccessor::GetRange(Sci_PositionU startPos_, Sci_PositionU endPos_, char *s, Sci_PositionU len) const noexcept {
 	assert(s != nullptr);
 	assert(startPos_ <= endPos_ && len != 0);
-	//memset(s, '\0', len);
+	//memset(s, 0, len);
 	endPos_ = sci::min(endPos_, startPos_ + len - 1);
 	//endPos_ = sci::min(endPos_, static_cast<Sci_PositionU>(lenDoc));
 	len = endPos_ - startPos_;

diff --git a/src/EditAutoC.cpp b/src/EditAutoC.cpp
@@ -33,7 +33,7 @@ class CharBuffer {
 	explicit CharBuffer(size_t size) noexcept {
 		if (size <= StackSize) {
 			ptr = buffer;
-			memset(buffer, '\0', StackSize);
+			memset(buffer, 0, StackSize);
 		} else {
 			ptr = static_cast<char *>(NP2HeapAlloc(size));
 		}