Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home: Sort leading emoji first in channel names #1234

Merged
merged 1 commit into from
Jan 23, 2025
Merged

home: Sort leading emoji first in channel names #1234

merged 1 commit into from
Jan 23, 2025

Conversation

lakshya1goel
Copy link
Contributor

Update the channel sorting logic to ensure streams with leading emojis in their names are listed above those without emojis. The updated sorting respects pinned, muted, and unmuted streams while handling emoji precedence and maintaining alphabetical order for ties.

Fixes: #1202

@lakshya1goel
Copy link
Contributor Author

Hello, @chrisbobbe I have done the required changes. Please have a look and let me know if anything else is required.
Thanks!

@PIG208 PIG208 added the maintainer review PR ready for review by Zulip maintainers label Jan 9, 2025
@lakshya1goel
Copy link
Contributor Author

Hi @chrisbobbe @PIG208
I just wanted to kindly follow up on this PR. I have made the changes requested, and I requested a review about two weeks ago. If you could take a moment to review it, I would greatly appreciate your feedback.
Thank you for your time and support!

chrisbobbe
chrisbobbe reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small comments below.

lib/widgets/subscription_list.dart Outdated Show resolved Hide resolved
lib/widgets/subscription_list.dart Outdated Show resolved Hide resolved
test/widgets/subscription_list_test.dart Outdated Show resolved Hide resolved
test/widgets/subscription_list_test.dart Show resolved Hide resolved
@lakshya1goel lakshya1goel force-pushed the issue1202 branch 2 times, most recently from 6167d68 to 0c567a3 Compare January 18, 2025 03:46
@lakshya1goel
Copy link
Contributor Author

Thanks for the detailed review. I have made the required changes.
Please have a look on it.

@lakshya1goel
Copy link
Contributor Author

Pushed the changes atop #1290 for the sake of CI.

chrisbobbe
chrisbobbe reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small comments below.

lib/widgets/subscription_list.dart Outdated Show resolved Hide resolved
test/widgets/subscription_list_test.dart Outdated Show resolved Hide resolved
@lakshya1goel
Copy link
Contributor Author

I have updated the commit message and the description of tests. Let me know if anything else is required.
Thanks!

@chrisbobbe
Copy link
Collaborator

Thanks! Marking for Greg's review.

@chrisbobbe chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Jan 22, 2025
@chrisbobbe chrisbobbe requested review from gnprice and removed request for chrisbobbe January 22, 2025 20:22
gnprice
gnprice reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@gnprice gnprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lakshya1goel for taking care of this, and @chrisbobbe for the previous reviews!

Generally this looks good. A couple of small comments below.

lib/widgets/subscription_list.dart Outdated Show resolved Hide resolved
test/widgets/subscription_list_test.dart Outdated Show resolved Hide resolved
lib/widgets/subscription_list.dart Show resolved Hide resolved
@lakshya1goel lakshya1goel requested a review from gnprice January 23, 2025 10:58
@lakshya1goel
Copy link
Contributor Author

Thanks for the review @gnprice , I have made the required changes, Please have a look on them.

@gnprice
Copy link
Member

gnprice commented Jan 23, 2025

Great, thanks. And yep, cutting those blank lines is the change I had in mind at #1234 (comment) .

All now looks good — merging.

@gnprice gnprice merged commit 12ce869 into zulip:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbobbe chrisbobbe chrisbobbe left review comments

@gnprice gnprice Awaiting requested review from gnprice

Assignees

@gnprice gnprice

Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort leading emoji first in channel names to match web
4 participants
@lakshya1goel @chrisbobbe @gnprice @PIG208