Retention of scroll offset in emoji #1269
Conversation
…nnecessary changes
|
Hello @chrisbobbe , |
| _viewModel!.query = newQuery; | ||
| // Reset scroll when query content changes | ||
| if (oldQuery.toString() != newQuery.toString() && |
There was a problem hiding this comment.
What's the output of toString?
How about using .raw instead.
There was a problem hiding this comment.
Also, this logic needs tests.
|
Thanks @AshutoshKhadse23 for picking this up! We're now focusing more strictly on launch issues until the app's launch is ready, and this is a post-launch issue. I'll leave this PR as an exception where we'll proceed with it anyway, because it looks like it may be possible for the fix to be quite small. The next step will be for you to revise it to address each of @chrisbobbe's comments above. Then we can give it a new round of review. Because we're prioritizing launch issues, this PR may wait longer for review than others. If you're interested in contributing to Zulip, I recommend taking a look also at open issues in the upcoming milestones up through M5 Launch. |
The issue regarding retention of scroll offset in emoji is solve
Resolving issue #1175
issue.1175.mp4