Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Dismiss Callback Method #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Fardinak
Copy link

@Fardinak Fardinak commented Oct 4, 2011

I've added a "dismisscallback" to the options so user can define a function to run after the close animation.
Really useful in my case

@paulbjensen
Copy link

+1

@Fardinak
Copy link
Author

This version won't work properly!
I made some new changes, I'll upload them as soon as possible...
maybe right now! :-?? :D

@mattdaly
Copy link

You need to use eval(options.dimisscallback) because the callback is stored as a string. I've added it (and a few other things (custom close key, timeout)) to my fork - https://github.com/mattdaly/reveal/commit/262216edcdee2ababfa961ebee1a3715d63af722

Edit: So apparently using eval is bad, I've stripped that out and no longer using it - https://github.com/mattdaly/reveal/commit/c1ed1e53f7b2f93e70eb04873b13ddcd1b6b81a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants