Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error catching added to workspace settings workflow #991

Open
wants to merge 50 commits into
base: dev
Choose a base branch
from
Open

Error catching added to workspace settings workflow #991

wants to merge 50 commits into from

Conversation

Lord-Chris
Copy link
Contributor

No description provided.

Lord_Chris and others added 30 commits October 7, 2021 17:57
Conflicts resolved
f9b64cd
Create organization with default email completed
742a186
Edit profile done
1e68b2d
resolved changes requested
443dd00
Merge remote-tracking branch 'upstream/dev' into editprofile
52bd906
Merge remote-tracking branch 'upstream/dev' into editprofile
122101a
Merge branch 'editprofile' of https://github.com/Lord-Chris/zc_app in…
facb22d 
…to editprofile
Conflicts merged
6b76025
Fixed edit profile feature
322d0e3
conflicts fixed
dd1148d
app bundle and package name changed
350837b
changed package id
386b71b
conflicts resolved
99c3b6a
fixed issues
0305c9b
Workspace settings, phase 1
cb2f927
workspace settings phase 2
0858d8d
Workspace Settings complete
b4cd5b4
Reverted package name change
0d5f542
Conflicts resolved, merged upstream
71a955b
Conflicts resolved, merged upstream
a9c1e47
Merge branch 'editprofile' of https://github.com/Lord-Chris/zc_app in…
dc15015 
…to editprofile
change resolved
c16b75d
@Lord-Chris
Merge branch 'dev' into editprofile
03e5b95
Conflicts resolved
6a7760f
Changes resolved 2
55a2255
Conflicts resolved 2
ac57717
Fixed conflicts again
752070c
Fixed conflicts again
e685891
Merge branch 'editprofile' of https://github.com/Lord-Chris/zc_app in…
ffd93ac 
…to editprofile
Merge branch 'editprofile' of https://github.com/Lord-Chris/zc_app in…
a00002e 
…to editprofile
@github-actions
Copy link

The status is success

@github-actions
Copy link

The status is success

jeremiahseun
jeremiahseun suggested changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@jeremiahseun jeremiahseun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix all conflicts

test/helpers/test_helpers.mocks.dart Outdated Show resolved Hide resolved
@github-actions
Copy link

The status is success

Lord-Chris
Lord-Chris commented Oct 16, 2021
View reviewed changes
Copy link
Contributor Author

@Lord-Chris Lord-Chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jeremiahseun jeremiahseun added bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on labels Oct 16, 2021
jeremiahseun
jeremiahseun suggested changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@jeremiahseun jeremiahseun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested

@jeremiahseun jeremiahseun added Changes requested and removed bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on labels Oct 16, 2021
@github-actions
Copy link

The status is success

pauleke65
pauleke65 previously approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@pauleke65 pauleke65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work

lib/ui/view/organization/organization_settings/organization_name_url.dart Outdated Show resolved Hide resolved
lib/ui/view/organization/organization_settings/organization_name_url.dart Outdated Show resolved Hide resolved
lib/ui/view/organization/organization_settings/organization_name_url.dart Outdated Show resolved Hide resolved
lib/ui/view/organization/organization_settings/organization_logo.dart Show resolved Hide resolved
lib/ui/view/organization/organization_settings/organization_logo.dart Outdated Show resolved Hide resolved
lib/ui/view/organization/organization_settings/organization_logo.dart Show resolved Hide resolved
lib/ui/view/organization/organization_settings/organization_name_url.dart Outdated Show resolved Hide resolved
lib/ui/view/organization/organization_settings/organization_settings_view.dart Outdated Show resolved Hide resolved
lib/ui/view/organization/organization_settings/organization_settings_view.dart Outdated Show resolved Hide resolved
lib/ui/view/organization/organization_settings/organization_settings_view.dart Outdated Show resolved Hide resolved
@github-actions
Copy link

The status is success

@github-actions
Copy link

The status is success

isaacadariku
isaacadariku approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@isaacadariku isaacadariku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiahseun jeremiahseun jeremiahseun requested changes

@isaacadariku isaacadariku isaacadariku approved these changes

@pauleke65 pauleke65 pauleke65 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lord-Chris @pauleke65 @isaacadariku @jeremiahseun