Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app converted to single-spa #255

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

multi-Adams
Copy link

No description provided.

@depecode
Copy link
Contributor

depecode commented Sep 18, 2021

This PR can not be merge..... You need to rebase the dev branch into your codebase and repush.

@multi-Adams
Copy link
Author

Did that since yesterday, can you check again?

Copy link
Contributor

@depecode depecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@depecode depecode self-requested a review September 20, 2021 18:39
@depecode
Copy link
Contributor

Your conversion is okay, But the installation has error....

@depecode
Copy link
Contributor

That is what I am also battle with the conversion that I did not submit my PR.

@multi-Adams
Copy link
Author

multi-Adams commented Sep 21, 2021

can you send the error to me on slack so i can have a look, user: @olodocoder thanks.
but everything worked fine locally on mine and i had no issues at all, even fixed the broken styles and fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants