Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Base variables as protected for scalabiity #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

compleatguru
Copy link

Hi!

I am proposing the changes so that anyone can extend your classes with ease and able to use them properly.

For your consideration, please.

@zxbodya
Copy link
Owner

zxbodya commented Apr 7, 2015

Hi, thanks.
Looks reasonable - partially merged your changes.

Except extending GalleryImage from yii\base\Model - why you need this?

@compleatguru
Copy link
Author

On extending GalleryImage from yii\base\Model, this will allow me to adopt multilingual behavoir for GalleryImage name and description.

In other words, each image can have its own name and description in different languages.

See https://github.com/OmgDef/yii2-multilingual-behavior.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants