Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zxlive.spec file for creating an executable using pyinstaller. #158

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

dlyongemallo
Copy link
Contributor

Note: Running this locally will result in an executable containing all the python modules in the virtual environment, which might be very large. For deployment, pyinstaller should be run in a virtual environment with the minimal required libraries.

Note: Running this locally will result in an executable containing all the python modules in the virtual environment, which might be very large. For deployment, pyinstaller should be run in a virtual environment with the minimal required libraries.
(The import file dialog will never allow a bad extension, but a user can enter one when launching from the command line.)
@jvdwetering jvdwetering merged commit 703530f into zxcalc:master Oct 31, 2023
2 checks passed
@dlyongemallo
Copy link
Contributor Author

dlyongemallo commented Oct 31, 2023

FYI: I tested the executable with PR #157 and the executable works as expected: it opens files specified on the command line. However, if a bad file is specified on the command line, issue #156 sometimes happens and the app can be started in a state that looks like it's frozen, because the error message dialog is hidden behind the main window (so the user would have to alt-tab or whatever and close it first before being able to use the app).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants