Add meson build system support #525
Conversation
Doxyfile.in
Outdated
There was a problem hiding this comment.
We already have a Doxyfile in the Zydis repository. Can we reuse this here? It seems that we are just using the default in Zycore. Optimally we'd make it consistent between both repos. If you can think of a way to reuse the existing Doxyfile here, please feel free to also add one based on the Zydis Doxyfile to Zycore.
There was a problem hiding this comment.
The existing Doxyfile needs to be parsed by a simple CMake function, and thus we can't add things like @DEFINES@, "quoted strings" and feature detection.
Another reason it could not be unified is that there are some minor differences between the repo (e.g. what macros to or not to expand, should add external includes or not).
I made it much simpler in 7272cde. It's now only the diffs with the default config.
There was a problem hiding this comment.
Thank you, that looks a lot more managable! Doxygen allows including another config as a basis via @INCLUDE = config_file_name. Can we perhaps use this to further deduplicate? I think I'd also prefer if we could rename Doxygen.in to Doxygen.meson.in to communicate the purpose of the extra file more clearly.
There was a problem hiding this comment.
Done, but I think this might bring some confusion, especially when someone uses in-tree build. (however, rare to see these days, so we could ignore that scenario.)
mochaaP
force-pushed
the
master
branch
2 times, most recently
from
5065520
to
862adb0
Compare
mochaaP
force-pushed
the
master
branch
4 times, most recently
from
72df9d2
to
6a383f5
Compare
|
Should be ready. |
subprojects
Outdated
There was a problem hiding this comment.
What is the symlink situation on Windows these days? It used to be a problem to have symlinks in git repos in the past. Seems that it is supported OK since some Windows 10 version? Does it have a reasonable user-experience, e.g. is the symlink marked as such in MS Explorer?
CC @Mattiwatti
There was a problem hiding this comment.
It should work well (iirc it shows as .symlink in explorer on Windows 8+)
There was a problem hiding this comment.
I did some research and it seems like it's still not possible to create symlinks on Windows 10 22H2 without administrator privileges by default.
Prior to Windows 10, the SeCreateSymbolicLinkPrivilege privilege must be granted to e.g. the Everyone group to allow the creation of symlinks without administrator privileges.
Since Windows 10, "Developer Mode" can be enabled to achieve the same.
I assume most developers on Windows have "Developer Mode" enabled, so from my side it would be fine to keep the symlink.
It looks like this after cloning the repo:
There was a problem hiding this comment.
Ok, thanks for checking! It's a bit of a recipe for confusion to make that behavior vary depending on developer mode, but that's MS fault and not ours. Let's merge and see if we receive issues from people running into this.
Requires zyantific/zycore-c#75.
Should've reached feature parity with CMake. Please let me know if I missed anything.