-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pure JS build #1365
Draft
matteopic
wants to merge
16
commits into
zzorba:master
Choose a base branch
from
matteopic:pure-js-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pure JS build #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd be quite happy to merge this once it is completed, I'm no fan of bash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Windows user I had some problem in generating correctly all app files because the presence of .sh files; I have also tried to run the build process in a linux system but there were some issues (with
<<<
elements).So I have started to convert the
.sh
files in pure javascript because theese script would works on both systems.I have also replaced the use of
jq
tool with theJSONata
library, because it does the same job and it is a pure javascript implementation, so there is no need to check for it's presence in the system.It has also a web page that let you to test the expression (like jq)
As you can see this is a pull request draft, implementation is not completed and needs more testing; if you are happy with those changes I can continue with this.