Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused remember_created_at user column #10429

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 15, 2024

🛠 Summary of changes

Removes the remember_created_at column from the users table.

This field is not currently used, and as best I can tell has never been referenced as far back as #1.

📜 Testing Plan

Verify migration runs cleanly:

rails db:migrate

Verify no lingering references to the removed column.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but because we have our code set to use explicit columns in SELECT statements, I think we need to add it as an ignored column first and then drop it in a second PR

@aduth
Copy link
Member Author

aduth commented Apr 15, 2024

LGTM but because we have our code set to use explicit columns in SELECT statements, I think we need to add it as an ignored column first and then drop it in a second PR

Ah, good call. I'll spin up a separate pull request for that.

@aduth
Copy link
Member Author

aduth commented Apr 15, 2024

LGTM but because we have our code set to use explicit columns in SELECT statements, I think we need to add it as an ignored column first and then drop it in a second PR

Do we document this anywhere?

@zachmargolis
Copy link
Contributor

LGTM but because we have our code set to use explicit columns in SELECT statements, I think we need to add it as an ignored column first and then drop it in a second PR

Do we document this anywhere?

If you read between the lines a bit, yes. (We could probably embellish that section of the page a bit)

aduth added 2 commits April 16, 2024 15:00
changelog: Internal, Database, Remove unused column from users table
@zachmargolis
Copy link
Contributor

LGTM but because we have our code set to use explicit columns in SELECT statements, I think we need to add it as an ignored column first and then drop it in a second PR

Do we document this anywhere?

If you read between the lines a bit, yes. (We could probably embellish that section of the page a bit)

PR to add documentation here: GSA-TTS/identity-handbook#538

@aduth aduth merged commit 17bdde4 into main Apr 17, 2024
2 checks passed
@aduth aduth deleted the aduth-rm-users-remember-created-at branch April 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants