-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused remember_created_at user column #10429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but because we have our code set to use explicit columns in SELECT statements, I think we need to add it as an ignored column first and then drop it in a second PR
Ah, good call. I'll spin up a separate pull request for that. |
Do we document this anywhere? |
If you read between the lines a bit, yes. (We could probably embellish that section of the page a bit) |
changelog: Internal, Database, Remove unused column from users table
7258afa
to
a3a8d83
Compare
PR to add documentation here: GSA-TTS/identity-handbook#538 |
🛠 Summary of changes
Removes the
remember_created_at
column from theusers
table.This field is not currently used, and as best I can tell has never been referenced as far back as #1.
📜 Testing Plan
Verify migration runs cleanly:
Verify no lingering references to the removed column.