Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the profile list to allow a user specified image for leap.2i2c.cloud - for all server options #2146

Closed
3 tasks done
Tracked by #3018
consideRatio opened this issue Feb 6, 2023 · 8 comments · Fixed by #2851 or #2865
Closed
3 tasks done
Tracked by #3018
Assignees

Comments

@consideRatio
Copy link
Contributor

consideRatio commented Feb 6, 2023

As requested in this support ticket, setup the ability for users of leap.2i2c.cloud to specify an image - independent of their server choice.

Action points

@GeorgianaElena
Copy link
Member

@consideRatio, this sounds like this could be achieved with the configurator?
If the configurator plays nicely with the kubespawner profiles, then setting the image in the configurator, then choosing a server option should be enough right?

Otherwise, I'm not sure specifying the image in an input text of some sort is possible with the current profiles implementation

@consideRatio
Copy link
Contributor Author

@GeorgianaElena I understand it as they are aware of the configurator, but still wanted to allow individual users to specify their own image for a specific server startup - also indepentent of being an admin or not.

@consideRatio
Copy link
Contributor Author

consideRatio commented Feb 7, 2023

@consideRatio
Copy link
Contributor Author

I'll close this for now.

@yuvipanda
Copy link
Member

@consideRatio can we keep this open until we can deploy the change?

@yuvipanda
Copy link
Member

Currently, manually testing works but our healthcheck fails with:

[E 2023-07-25 07:58:24.152 JupyterHub user:884] Unhandled error starting deployment-service-check's server: Expected option image for profile medium-full or image--unlisted-choice, not found in posted form
    Traceback (most recent call last):
      File "/usr/local/lib/python3.11/site-packages/jupyterhub/user.py", line 798, in spawn
        url = await gen.with_timeout(timedelta(seconds=spawner.start_timeout), f)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/home/jovyan/.local/lib/python3.11/site-packages/jupyterhub_configurator/mixins.py", line 45, in start
        return await super().start(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/home/jovyan/.local/lib/python3.11/site-packages/kubespawner/spawner.py", line 2656, in _start
        await self.load_user_options()
      File "/home/jovyan/.local/lib/python3.11/site-packages/kubespawner/spawner.py", line 3232, in load_user_options
        await self._load_profile(
      File "/home/jovyan/.local/lib/python3.11/site-packages/kubespawner/spawner.py", line 3123, in _load_profile
        self._validate_posted_profile_options(
      File "/home/jovyan/.local/lib/python3.11/site-packages/kubespawner/spawner.py", line 3033, in _validate_posted_profile_options
        raise ValueError(
    ValueError: Expected option image for profile medium-full or image--unlisted-choice, not found in posted form

@yuvipanda
Copy link
Member

This was reverted in #3007.

@yuvipanda
Copy link
Member

This was done again in #3047! Thanks to @GeorgianaElena!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
3 participants