-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarly set user_options for test users and leap hubs #2865
Conversation
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
hmm ⬆️ modifying the test, shouldn't actually trigger the hubs to deploy. Maybe we can exclude this test file from the triggers |
I think we should actually just put the deployer in it's own repo |
@sgibson91, agree! Until then, I've opened #2866 |
ef76e9d
to
625f926
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s open an issue to track reverting this? Otherwise lgtm
Opened #2869 to track reverting this. Thank you! |
I manually re-deployed the staging and the prod hubs for leap to get the |
Fixes #2146
A persistent fix requires some cleanup related to profile handling in
kubespawner
so that it's easier to see where default settings are failing or if they are inconsistent (tracked in jupyterhub/kubespawner#758)