Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarly set user_options for test users and leap hubs #2865

Merged
merged 1 commit into from
Jul 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions deployer/tests/test_hub_health.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ async def check_hub_health(hub_url, test_notebook_path, service_api_token):
# This is because we would have lost its api token from the previous run.
await hub.delete_user(username)

# Temporary fix for https://github.com/2i2c-org/infrastructure/issues/2146#issuecomment-1649445203
# FIXME: Remove this once a fix in kubespawner gets implemented
user_options = {}
if "leap" in hub_url:
user_options = {
"profile": "medium-full",
"requests": "mem_8",
"image": "pangeo",
}

# Create a new user, start a server and execute a notebook
await execute_notebook(
hub_url,
Expand All @@ -52,6 +62,7 @@ async def check_hub_health(hub_url, test_notebook_path, service_api_token):
delete_user=False, # To be able to delete its server in case of failure
stop_server=True, # If the health check succeeds, this will delete the server
validate=False, # Don't validate notebook outputs. We only care that it runs top-to-bottom without error.
user_options=user_options,
)
finally:
if orig_service_token:
Expand Down