Disable hook prePuller for three communites using the jupyterhub configurator #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/stop-hook-puller-for-three-hubs
branch
from
94d2b30 to
d93bfa5
Compare
consideRatio
changed the title
consideRatio
commented
Nov 3, 2023
| # pullPolicy set to "Always" because we use the changing over time tag | ||
| # "latest". | ||
| pullPolicy: Always | ||
| tag: "latest" |
There was a problem hiding this comment.
QCL are using latest tags for their configured images, but pullPolicy defaults to the Always behavior when unspecified and the tag is latest anyhow.
There was a problem hiding this comment.
We just discovered that this is actually not true, due to a kubespawner bug. jupyterhub/kubespawner#807 has details.
There was a problem hiding this comment.
#3396 temporarily sets imagePullPolicy again
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
yuvipanda
reviewed
Nov 6, 2023
|
Thank you for reviewing @yuvipanda !! |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6775757471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since callysto, qcl, and 2i2c/climatematch are all using the configurator, they don't have any benefit from the hook prePuller so this PR disables it for these hubs to reduce unessecary complexity and false expectations from the config.
These are commits extracted from #3341 that as a whole can't be merged short term