Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hook prePuller for three communites using the jupyterhub configurator #3371

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Disable hook prePuller for three communites using the jupyterhub configurator #3371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a379d8a
callysto: disable hook prePuller, the configurator is actively used
consideRatio Oct 29, 2023
7e655e9
qcl: disable hook prePuller, the configurator is actively used
consideRatio Oct 29, 2023
d93bfa5
2i2c/climatematch: disable hook prePuller, the configurator is active…
consideRatio Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions config/clusters/2i2c/climatematch.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
jupyterhub:
prePuller:
# hook prePuller shouldn't be enabled when configuring images in any other
# way than singleuser.image
hook:
enabled: true
singleuser:
memory:
limit: 16G
Expand All @@ -16,9 +11,6 @@ jupyterhub:
value: "climatematch"
effect: "NoSchedule"
defaultUrl: /lab
image:
name: wesleyban/climatematch-notebook
tag: v0.1
# shared-public for collaboration
# See https://github.com/2i2c-org/infrastructure/issues/2785
storage:
Expand Down
8 changes: 0 additions & 8 deletions config/clusters/callysto/common.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ nfs:
# Name of Google Filestore share
baseShareName: /homes/
jupyterhub:
prePuller:
# hook prePuller shouldn't be enabled when configuring images in any other
# way than singleuser.image
hook:
enabled: true
custom:
2i2c:
# add_staff_user_ids_to_admin_users is disabled because the usernames
Expand All @@ -37,9 +32,6 @@ jupyterhub:
name: Callysto
url: https://www.callysto.ca
singleuser:
image:
yuvipanda marked this conversation as resolved.
Show resolved Hide resolved
name: callysto/2i2c
tag: 0.1.4
extraFiles:
tree.html:
mountPath: /usr/local/share/jupyter/custom_template/tree.html
Expand Down
12 changes: 0 additions & 12 deletions config/clusters/qcl/common.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ nfs:
# Name of Google Filestore share
baseShareName: /homes/
jupyterhub:
prePuller:
# hook prePuller shouldn't be enabled when configuring images in any other
# way than singleuser.image
hook:
enabled: true
custom:
2i2c:
add_staff_user_ids_to_admin_users: true
Expand Down Expand Up @@ -48,13 +43,6 @@ jupyterhub:
- gizmo404
- jtkmckenna
singleuser:
image:
# pangeo/pangeo-notebook is maintained at: https://github.com/pangeo-data/pangeo-docker-images
name: pangeo/pangeo-notebook
# pullPolicy set to "Always" because we use the changing over time tag
# "latest".
pullPolicy: Always
tag: "latest"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QCL are using latest tags for their configured images, but pullPolicy defaults to the Always behavior when unspecified and the tag is latest anyhow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just discovered that this is actually not true, due to a kubespawner bug. jupyterhub/kubespawner#807 has details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3396 temporarily sets imagePullPolicy again

profileList:
# NOTE: About node sharing
#
Expand Down