Enable pathways workloads for v6e benchmarks #1040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2024 08:33
sadikneipp
requested review from
gobbleturk,
jonb377,
khatwanimohit,
bvandermoon and
vipannalla
as code owners
sadikneipp
changed the title
RoshaniN
requested changes
Nov 15, 2024
| ): | ||
| config_tuning_params = '' | ||
| for key, value in model.tuning_params.items(): | ||
| config_tuning_params += f'{key}={value} ' | ||
|
|
||
| install_libtpu_cmd = '' | ||
| if libtpu_type == LibTpuType.NIGHTLY: | ||
| if use_pathways: | ||
| pass |
There was a problem hiding this comment.
For future - Should we perhaps give users a message that we won't be running Pathways with nightly Libtpu?
| if use_pathways: | ||
| pathways_specific_flags = ( | ||
| ' --use-pathways' | ||
| f' --additional_pw_proxy_args={reformat_xla_flags_for_xpk(model.xla_flags)}' |
There was a problem hiding this comment.
I think you need hyphens instead of underscores here in "--additional_pw_proxy_args" to be consistent with rest of the parsed args in XPK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes to ensure pathways can share the benchmarking infrastructure.
Changes:
additional_pw_proxy_argsto ensure XLA flags curated by maxtext are passed to the pathways proxy server. See Add custom pw proxy args support xpk#249