Add custom pw proxy args support #249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadikneipp
requested review from
Obliviour,
44past4,
sharabiani,
pawloch00 and
BluValor
as code owners
sadikneipp
commented
Nov 15, 2024
| @@ -60,6 +60,8 @@ def get_pathways_proxy_args(args) -> str: | |||
| yaml = """- --server_port=29000 | |||
| - --resource_manager_address={rm_address} | |||
| - --gcs_scratch_location={args.pathways_gcs_location}""" | |||
| if args.additional_pw_proxy_args: | |||
| yaml += args.additional_pw_proxy_args.replace(' ', '\n' + ' '*14 +'- ') | |||
|
|
|||
There was a problem hiding this comment.
Would appreciate some guidance for this line, hopefully there's some way to ensure relative alignment between lines. Without this alignment fix the yaml would not be parsed correctly.
There was a problem hiding this comment.
Maybe:
Suggested change
| additional_pw_proxy_string = '' | |
| if args.additional_pw_proxy_args: | |
| additional_pw_proxy_string = #construct your string here | |
| yaml = """ | |
| ... | |
| - {intendation_string}{additional_pw_proxy_string} | |
There was a problem hiding this comment.
I don't get why there are 14 spaces needed?
|
Please fix linting and build issues before requesting review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
For now XLA flags are being concentrated on the proxy server. Ideally they will all move to the client and cease being container level flags to become jax-code level flags. This flag will be used in a PR to the benchmarks scripts in maxtext: AI-Hypercomputer/maxtext#1040
Testing / Documentation
Validated on v6e cluster, end to end tests WIP