You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2456 showed that we need the parameter table for proper PEtab import, but there is no option to pass the parameter table as individual file (since in the early days, we didn't (think we'd) need it). To avoid any surprises and wrong gradients there, I'd suggest to remove this functionality as part of fixing #2455.
There has been a DeprecationWarning in place for almost 2 years (#1810) and I think this isn't used anyways.
Independent of this specific issue, I think it would be good to allow removing deprecated functionality not only in major releases, but also in minor releases after a certain transition period (maybe 1y after the first release containing the deprecation warning? after 3 minor releases? ...? See also, for example, numpy's policy). Opinions? @FFroehlich?
The text was updated successfully, but these errors were encountered:
…s instead of petab.Problem
Since almost two years, it's possible to pass a `petab.Problem`, which is safer
and more convenient.
Omitting the parameter table for model import (since there is no option to supply
this) is likely to produce unwanted results (see AMICI-dev#2458 and AMICI-dev#2455 for more details),
and therefore, this functionality is best removed.
Remove deprecated functionality for PEtab import from individual files instead of petab.Problem:
AMICI/python/sdist/amici/petab/sbml_import.py
Lines 32 to 37 in 3fbb90b
#2456 showed that we need the parameter table for proper PEtab import, but there is no option to pass the parameter table as individual file (since in the early days, we didn't (think we'd) need it). To avoid any surprises and wrong gradients there, I'd suggest to remove this functionality as part of fixing #2455.
There has been a DeprecationWarning in place for almost 2 years (#1810) and I think this isn't used anyways.
Independent of this specific issue, I think it would be good to allow removing deprecated functionality not only in major releases, but also in minor releases after a certain transition period (maybe 1y after the first release containing the deprecation warning? after 3 minor releases? ...? See also, for example, numpy's policy). Opinions? @FFroehlich?
The text was updated successfully, but these errors were encountered: