Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExpData::clear_observations #2258

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 4, 2024

Makes it more convenient to unset all measurements, e.g. if one wants to run a simulation for a given experimental condition but with additional output timepoints while ignoring previously set measuremnts.

Makes it more convenient to unset all measurements, e.g. if one
wants to run a simulation for a given experimental condition but
with additional output timepoints while ignoring previously set
measuremnts.
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d01ebb) 77.07% compared to head (cb65c80) 52.90%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2258       +/-   ##
============================================
- Coverage    77.07%   52.90%   -24.18%     
============================================
  Files           92       44       -48     
  Lines        14980     5567     -9413     
============================================
- Hits         11546     2945     -8601     
+ Misses        3434     2622      -812     
Flag Coverage Δ
cpp ?
cpp_python ?
petab 52.90% <ø> (ø)
python ?
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 68 files with indirect coverage changes

@dweindl dweindl self-assigned this Jan 4, 2024
@dweindl dweindl marked this pull request as ready for review January 8, 2024 11:06
@dweindl dweindl requested a review from a team as a code owner January 8, 2024 11:06
@dweindl dweindl merged commit 434e7be into AMICI-dev:develop Jan 8, 2024
17 of 20 checks passed
@dweindl dweindl deleted the ExpData_clear_observations branch January 8, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants