Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEtab: Fix estimated initial conditions specified via the conditions table #2456

Merged
merged 6 commits into from
Jun 16, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 12, 2024

  • For reinitialization of state variables after preequilibration, we need to add fixed parameters for initial conditions (otherwise parameter values can't be different for pre-equilibration and the following period). This case was handled fine.
  • If we want to estimate initial conditions and want to compute sensitivities w.r.t. those, we need non-fixed parameters for the initial conditions. This was not handled correctly, those were added as fixed parameters.
  • As a consequence, we can't handle reinitialization and estimation of initial values for the same state variable.

Closes #2455.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.65%. Comparing base (2b8c6a2) to head (531a2a5).
Report is 30 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2456   +/-   ##
========================================
  Coverage    77.64%   77.65%           
========================================
  Files          324      324           
  Lines        20927    20927           
  Branches      1464     1464           
========================================
+ Hits         16248    16250    +2     
+ Misses        4676     4674    -2     
  Partials         3        3           
Flag Coverage Δ
cpp 73.41% <ø> (ø)
cpp_python 34.09% <ø> (ø)
petab 36.66% <ø> (+0.01%) ⬆️
python 72.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/cli/import_petab.py 0.00% <ø> (ø)
python/sdist/amici/petab/import_helpers.py 86.15% <ø> (+3.07%) ⬆️
python/sdist/amici/petab/sbml_import.py 54.28% <ø> (ø)

@dweindl dweindl merged commit 3fbb90b into AMICI-dev:develop Jun 16, 2024
20 checks passed
@dweindl dweindl deleted the fix_2455_petab_est_ic branch June 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants