Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PEtab SciML in jax #2614

Draft
wants to merge 39 commits into
base: develop
Choose a base branch
from

update after test refactor

bd103db
Select commit
Loading
Failed to load commit list.
Draft

Support for PEtab SciML in jax #2614

update after test refactor
bd103db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 19, 2024 in 0s

73.74% (-3.30%) compared to 1716181

View this Pull Request on Codecov

73.74% (-3.30%) compared to 1716181

Details

Codecov Report

Attention: Patch coverage is 26.11111% with 133 lines in your changes missing coverage. Please review.

Project coverage is 73.74%. Comparing base (1716181) to head (bd103db).

Files with missing lines Patch % Lines
python/sdist/amici/jax/nn.py 13.69% 63 Missing ⚠️
python/sdist/amici/de_model.py 7.89% 35 Missing ⚠️
python/sdist/amici/jax/petab.py 44.64% 31 Missing ⚠️
python/sdist/amici/jax/ode_export.py 66.66% 2 Missing ⚠️
python/sdist/amici/jax/jaxcodeprinter.py 50.00% 1 Missing ⚠️
python/sdist/amici/sbml_import.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2614      +/-   ##
===========================================
- Coverage    77.03%   73.74%   -3.30%     
===========================================
  Files          332      326       -6     
  Lines        22970    21958    -1012     
  Branches      1478     1457      -21     
===========================================
- Hits         17695    16192    -1503     
- Misses        5264     5757     +493     
+ Partials        11        9       -2     
Files with missing lines Coverage Δ
python/sdist/amici/de_export.py 89.05% <100.00%> (-6.29%) ⬇️
python/sdist/amici/jax/__init__.py 100.00% <ø> (ø)
python/sdist/amici/jax/model.py 82.60% <100.00%> (-4.56%) ⬇️
python/sdist/amici/petab/parameter_mapping.py 48.01% <100.00%> (-33.92%) ⬇️
python/sdist/amici/petab/petab_import.py 66.66% <ø> (-9.61%) ⬇️
python/sdist/amici/petab/sbml_import.py 37.19% <ø> (-38.84%) ⬇️
python/sdist/amici/petab/util.py 43.33% <ø> (-37.62%) ⬇️
python/sdist/amici/jax/jaxcodeprinter.py 81.81% <50.00%> (-2.80%) ⬇️
python/sdist/amici/sbml_import.py 77.52% <50.00%> (-1.95%) ⬇️
python/sdist/amici/jax/ode_export.py 94.54% <66.66%> (-2.33%) ⬇️
... and 3 more

... and 55 files with indirect coverage changes