Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a tiling issue with the shock detection #3019

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

zingale
Copy link
Member

@zingale zingale commented Jan 16, 2025

we need to grow the q FAB, not use a growntilebox() this only affects CPUs, and only seemed to be an issue in 3D

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

we need to grow the q FAB, not use a growntilebox()
this only affects CPUs, and only seemed to be an issue in 3D
@zingale
Copy link
Member Author

zingale commented Jan 16, 2025

this fixes Array4 bounds errors seen with subchandra in 3D on CPU.

@zingale zingale merged commit 057363c into AMReX-Astro:development Jan 17, 2025
25 checks passed
@zingale zingale deleted the fix_3d_shock_cpu branch January 17, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants