Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a tiling issue with the shock detection #3019

Merged
merged 2 commits into from
Jan 17, 2025
+1 −1
Merged

fix a tiling issue with the shock detection #3019

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b6ed03
fix a tiling issue with the shock detection
zingale Jan 16, 2025
5ae7dae
Merge branch 'development' into fix_3d_shock_cpu
zingale Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix a tiling issue with the shock detection 
we need to grow the q FAB, not use a growntilebox()
this only affects CPUs, and only seemed to be an issue in 3D
@zingale
zingale committed Jan 16, 2025
commit 1b6ed03e9cf58ae3f83931877f977ada5488bcb9
2 changes: 1 addition & 1 deletion Source/sources/Castro_sources.cpp
View file
Original file line number Diff line number Diff line change
@@ -561,7 +561,7 @@ Castro::pre_advance_operators (Real time, Real dt) // NOLINT(readability-conver

for (MFIter mfi(Sborder, TilingIfNotGPU()); mfi.isValid(); ++mfi) {
const Box& bx = mfi.tilebox();
const Box& obx = mfi.growntilebox(1);
const Box& obx = amrex::grow(bx, 1);

shk.resize(bx, 1);
#ifdef RADIATION