Cleanup #103
Merged
Cleanup #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cgilet
commented
Jun 10, 2024
cgilet
commented
- Make first call to compute_vel_forces in ApplyPredictor safer for new forms of the forcing term. For the forcing terms currently in incflo, the old way was fine and this code change should not alter results. However, for restart, only old time data is guaranteed to be FillPatched at this point. So, since old and new represent the same data at this point in the code, this is a safer choice for more general forms of the forcing term that users may wish to introduce.
- Add time step options to Docs
- Add a comment, fix typo and outdated info in other comments.
new forms of the forcing term. Also add a comment and fix typo in another comment. For the forcing terms currently in incflo, the old way was fine and this code change should not alter results. However, for restart, only old time data is guaranteed to be FillPatched at this point. So, since old and new represent the same data at this point in the code, this is a safer choice for more general forms of the forcing term that users may wish to introduce.
asalmgren
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.