Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #103

Merged
merged 3 commits into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Docs/sphinx_documentation/source/InputsTimeStepping.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ The inputs below must be preceded by "incflo."
+----------------------+-----------------------------------------------------------------------+-------------+--------------+
| cfl | CFL constraint (dt < cfl * dx / u) if fixed_dt not > 0 | Real | 0.5 |
+----------------------+-----------------------------------------------------------------------+-------------+--------------+
| dt_change_max | maximum percentage dt can increase | Real | 1.1 |
+----------------------+-----------------------------------------------------------------------+-------------+--------------+
| init_shrink | reduce the initial time step by this safety factor | Real | 0.1 |
+----------------------+-----------------------------------------------------------------------+-------------+--------------+

Setting the Time Step
---------------------
Expand Down
5 changes: 3 additions & 2 deletions src/incflo_apply_predictor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ using namespace amrex;
//
// vel = u** - dt * grad p / rho^nph
//
// It is assumed that the ghost cels of the old data have been filled and
// It is assumed that the ghost cells of the old data have been filled and
// the old and new data are the same in valid region.
//
void incflo::ApplyPredictor (bool incremental_projection)
Expand Down Expand Up @@ -139,6 +139,7 @@ void incflo::ApplyPredictor (bool incremental_projection)

// *************************************************************************************
// Compute explicit viscous term
// Note that for !advect_momentum, this actually computes divtau / rho
// *************************************************************************************
if (need_divtau() || use_tensor_correction )
{
Expand All @@ -160,7 +161,7 @@ void incflo::ApplyPredictor (bool incremental_projection)
// *************************************************************************************
bool include_pressure_gradient = !(m_use_mac_phi_in_godunov);
compute_vel_forces(GetVecOfPtrs(vel_forces), get_velocity_old_const(),
get_density_old_const(), get_tracer_old_const(), get_tracer_new_const(),
get_density_old_const(), get_tracer_old_const(), get_tracer_old_const(),
include_pressure_gradient);
compute_MAC_projected_velocities(get_velocity_old_const(), get_density_old_const(),
AMREX_D_DECL(GetVecOfPtrs(u_mac), GetVecOfPtrs(v_mac),
Expand Down
2 changes: 1 addition & 1 deletion src/incflo_compute_dt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ void incflo::ComputeDt (int initialization, bool explicit_diffusion)
dt_new = Real(0.5) * m_dt;
}

// Don't let the timestep grow by more than 10% per step
// Don't let the timestep grow by more than m_dt_change_max per step
// unless the previous time step was unduly shrunk to match m_plot_per_exact
Real allowed_change_factor = m_dt_change_max;
if( (m_dt > Real(0.0)) && !(m_plot_per_exact > 0 && m_last_plt == m_nstep && m_nstep > 0) )
Expand Down
Loading