Add mixed bc and update docs #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal or external flow.
and half flows in one direction and the other half the opposite dir
renamed: incflo_set_velocity_bcs.cpp -> incflo_set_bcs.cpp
be better to use a PhysBCFunct...
renamed: incflo_set_velocity_bcs.cpp -> incflo_set_bcs.cpp
internal or external flow.
PhysBCFunct, which we use to set the inflow bcs during FillPatch.
The rest should stay zero.
Conflicts: src/boundary_conditions/incflo_set_bcs.cpp src/incflo.H src/prob/prob_bc.cpp
the appropriate setup in inputs.split). advection not working (hacked to get umac to project) not in any way elegantly coded Also requires minor update in AMReX-Hydro to pass through robin BC for MAC projector
at cgilet fork f2717ac
fixes. Use with cgilet hydro fdbb31e
necessary and can lead to false problems in the InitialProj when running debug
add mixed BCs. Ultimately, the different pieces need the BC info in slightly different ways, so just make it on the spot.
either 0 or 1 only. MLMG does use an overset mask as a boolean, but internally it creates that mask from 1-(mask passed in). Also includes minor clean up, comment improvement
is nodal type. This shouldn't change any results, just fixes things for debug.
bcs as ext_dir. This shouldn't change results; the error of filling all the mixed boundry face as ext_dir doesn't matter because the overset mask overrides the incorrect portion.
asalmgren
approved these changes
Mar 15, 2024
siddanib
pushed a commit
to siddanib/incflo
that referenced
this pull request
Apr 2, 2024
This allows inflow and outflow on the same domain face, where the Dirichlet and Neumann regions are separated by an EB. Depends on Hydro pr 126 and AMReX PR 3788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on Hydro pr 126