Fix part controller demo #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: You Liang Tan <[email protected]>
Signed-off-by: You Liang Tan <[email protected]>
Signed-off-by: You Liang Tan <[email protected]>
Signed-off-by: You Liang Tan <[email protected]>
Abhiram824
reviewed
Nov 5, 2024
robosuite/controllers/composite/composite_controller_factory.py
Outdated
Show resolved
Hide resolved
Abhiram824
reviewed
Nov 5, 2024
Abhiram824
reviewed
Nov 5, 2024
Abhiram824
reviewed
Nov 5, 2024
Abhiram824
requested changes
Nov 5, 2024
Merged
kevin-thankyou-lin
requested changes
Nov 6, 2024
…into fix-part-controller-demo
kevin-thankyou-lin
approved these changes
Nov 6, 2024
Abhiram824
reviewed
Nov 6, 2024
Abhiram824
reviewed
Nov 6, 2024
There was a problem hiding this comment.
do we need to change the key from body_parts to body_parts_controller_config I think if don't do this. This PR will have less changes
There was a problem hiding this comment.
I think updating is fine for consistency?
kevin-thankyou-lin
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
I think updating is fine for consistency?
Abhiram824
approved these changes
Nov 7, 2024
|
Resolves issue #534 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses both of these issues related to the controller.
Demo scripts bugs #534
Bug when update to 1.5.0 #532
This PR added the previous v1.4 controller configs, so users can still initiate only a single controller (as opposed to
composite), via theload_part_controller_config()` method.Also there are some inconsistency of using
body_partsin the internal implementation of handlingcontroller_configs, I kept it consistent with thebody_parts_controller_configskey. Still, I not a fan of dynamically changing the config dict in the internal method.fixes the
demo_control.pyandtune_joints.pyscripts.What to Run
Also all test cases passed.