Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add SonarCloud configuration #464

Closed

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Mar 30, 2021

#440

Adds SonarCloud configuration to the pom and GitHub Actions workflow. I think this should be sufficient to trigger SonarCLoud analyses.

@slarse slarse added the WiP label Mar 31, 2021
@slarse
Copy link
Collaborator Author

slarse commented Apr 13, 2021

For future reference, the problem here causing SonarCloud not to run is that the token is not available to a PR from a fork (for security reasons). See #465 for a PR within this repo, to which the token is available.

@slarse
Copy link
Collaborator Author

slarse commented Apr 19, 2021

Replaced with #465

@slarse slarse closed this Apr 19, 2021
@slarse slarse deleted the issue/440-add-sonarcloud-stuff branch April 19, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant