-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add SonarCloud config #465
Conversation
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
=========================================
Coverage 89.49% 89.49%
Complexity 541 541
=========================================
Files 66 66
Lines 1819 1819
Branches 148 148
=========================================
Hits 1628 1628
Misses 117 117
Partials 74 74 Continue to review full report at Codecov.
|
Per our conversation, we want to merge this but we don't want comment to posted, we want only the Github PR status check. |
SonarCloud Quality Gate failed.
|
Test failures probably due to GHA backend trouble: https://www.githubstatus.com/incidents/cj7gzzj30411 |
@monperrus This is now ready for merge. I've disabled PR comments in the SonarCloud UI, so we'll see if it honors that. Note that the PR status check will not be posted on PRs that originate from forks, due to the security implications we discussed earlier. This seems to be something of an unsolved problem for SonarCloud, see e.g. this SO post and the fact that the Travis plugin has it as an upcoming feature. We can work around that by our members working within the repository instead of on private forks, but external contributors won't have their code vetted by SonarCloud. |
LGTM. |
@fermadeiral feel free to merge! |
Ok! Thank you, @slarse! |
great milestone, thanks!
|
Carbon copy of #464, but the head is in the SpoonLabs/Sorald repo instead of my personal fork.