Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add SonarCloud config #465

Merged
merged 8 commits into from
Apr 21, 2021
Merged

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Mar 30, 2021

Carbon copy of #464, but the head is in the SpoonLabs/Sorald repo instead of my personal fork.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #465 (42db532) into master (1bfe693) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #465   +/-   ##
=========================================
  Coverage     89.49%   89.49%           
  Complexity      541      541           
=========================================
  Files            66       66           
  Lines          1819     1819           
  Branches        148      148           
=========================================
  Hits           1628     1628           
  Misses          117      117           
  Partials         74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bfe693...42db532. Read the comment docs.

@slarse slarse added the WiP label Mar 31, 2021
@monperrus
Copy link
Contributor

Per our conversation, we want to merge this but we don't want comment to posted, we want only the Github PR status check.

@sonarqubecloud
Copy link

@slarse
Copy link
Collaborator Author

slarse commented Apr 21, 2021

Test failures probably due to GHA backend trouble: https://www.githubstatus.com/incidents/cj7gzzj30411

@slarse slarse closed this Apr 21, 2021
@slarse slarse reopened this Apr 21, 2021
@slarse
Copy link
Collaborator Author

slarse commented Apr 21, 2021

@monperrus This is now ready for merge.

I've disabled PR comments in the SonarCloud UI, so we'll see if it honors that.

Note that the PR status check will not be posted on PRs that originate from forks, due to the security implications we discussed earlier. This seems to be something of an unsolved problem for SonarCloud, see e.g. this SO post and the fact that the Travis plugin has it as an upcoming feature.

We can work around that by our members working within the repository instead of on private forks, but external contributors won't have their code vetted by SonarCloud.

@fermadeiral
Copy link
Collaborator

LGTM.

@slarse
Copy link
Collaborator Author

slarse commented Apr 21, 2021

@fermadeiral feel free to merge!

@fermadeiral
Copy link
Collaborator

Ok! Thank you, @slarse!

@fermadeiral fermadeiral merged commit c9b278c into master Apr 21, 2021
@slarse slarse deleted the issue/440-add-sonarcloud-stuff branch April 22, 2021 06:26
@monperrus
Copy link
Contributor

monperrus commented Apr 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants