Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch bug bug fixes #208

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

sopa301
Copy link
Collaborator

@sopa301 sopa301 commented Nov 5, 2023

fixes #160, #170, #177, #181, #182, #184, #203

We make the error message of tag explicit (because it causes confusion)
and make it clear in the UG about the current limits of the phone field and the
duplicate checking ability of the app.
Also, fixed more documentation bugs.
@sopa301 sopa301 added bug Something isn't working documentation Improvements or additions to documentation labels Nov 5, 2023
@sopa301 sopa301 added this to the v1.4 milestone Nov 5, 2023
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #208 (88ff2ba) into master (b807645) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #208   +/-   ##
=========================================
  Coverage     75.66%   75.66%           
  Complexity      667      667           
=========================================
  Files           101      101           
  Lines          2153     2153           
  Branches        228      228           
=========================================
  Hits           1629     1629           
  Misses          461      461           
  Partials         63       63           
Files Coverage Δ
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <ø> (ø)
src/main/java/seedu/address/model/tag/Tag.java 73.33% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@AlyssaPng AlyssaPng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sopa301 sopa301 merged commit 2d4a0ab into AY2324S1-CS2103T-F12-1:master Nov 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment