forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch bug bug fixes #208
Merged
sopa301
merged 6 commits into
AY2324S1-CS2103T-F12-1:master
from
sopa301:branch-bug-bugFixes
Nov 6, 2023
Merged
Branch bug bug fixes #208
sopa301
merged 6 commits into
AY2324S1-CS2103T-F12-1:master
from
sopa301:branch-bug-bugFixes
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We make the error message of tag explicit (because it causes confusion) and make it clear in the UG about the current limits of the phone field and the duplicate checking ability of the app.
Also, fixed more documentation bugs.
sopa301
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Nov 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=========================================
Coverage 75.66% 75.66%
Complexity 667 667
=========================================
Files 101 101
Lines 2153 2153
Branches 228 228
=========================================
Hits 1629 1629
Misses 461 461
Partials 63 63
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Kb-Tay
reviewed
Nov 5, 2023
AlyssaPng
reviewed
Nov 6, 2023
This was
linked to
issues
Nov 6, 2023
Closed
AlyssaPng
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #160, #170, #177, #181, #182, #184, #203