Implement simpler !tnt controls
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPS can take up to a minute to stabilize. 18.5 seems to be enough for the server to be performing well.
Added the option to specified predefined values for yaw, pitch, ttl and power/distance. The values come from words that are easier to understand for players (e.g. "north" for yaw, "up" for pitch, etc.). Shorthands for the words are also supported (e.g. "q" for "quick"). Default values are provided for pitch, distance and ttl. Yaw is always required. Finally, the words do not need to be in a given sequence. Since all of them are different, we can parse them in any order.
|
Thank you very much for doing this. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
I'd been wanting to do this for a while, and today felt like a good day to do it.
This implements a new system of parameters for the
!tntcommand. This does not replace the previous system, but rather is a simpler alternative. The best way I can summarize how this work is with this "guide" I made:Guide
(Feel free to add this to the guide doc.)
Basically, the parameters are the same. What changes is:
yawis required in the command. Everything else has a default value if not specified.yawcan be specified with:top/right/bottom/left) and shorthands (t/r/b/l).north,southwest) and shorthands (e.g.n,sw).pitchwithup/down(andu/d).powerwithclose/far/veryfar(c/f/v).ttlwithquick/slow(q/o).Overall this makes the command easier to use, and it makes it harder to write it in an invalid way.
Besides this change, I also updated the required TPS for the game to start. It seems like the
/tpscommand only updates once per minute, so it can take up to that much for the game to start even if the server is already performing well. Based on some quick testing,18.5seems to be a good value for this.Demo
Recorded a demo with some examples:
ARSimpleDemo.mp4