chore: chain policy limits

multichain-testing/test/fast-usdc/config.ts

@@ -1,4 +1,5 @@
 import type { IBCChannelID } from '@agoric/vats';
+import type { FeedPolicy } from '@agoric/fast-usdc/src/types.js';
 
 export const oracleMnemonics = {
   oracle1:
@@ -10,19 +11,12 @@ export const oracleMnemonics = {
 };
 harden(oracleMnemonics);
 
-export const makeFeedPolicy = (nobleAgoricChannelId: IBCChannelID) => {
+export const makeFeedPolicy = (
+  nobleAgoricChannelId: IBCChannelID,
+): Omit<FeedPolicy, 'chainPolicies'> => {
   return {
     nobleAgoricChannelId,
     nobleDomainId: 4,
-    chainPolicies: {
-      Arbitrum: {
-        attenuatedCttpBridgeAddress:
-          '0xe298b93ffB5eA1FB628e0C0D55A43aeaC268e347',
-        cctpTokenMessengerAddress: '0x19330d10D9Cc8751218eaf51E8885D058642E08A',
-        chainId: 42161,
-        confirmations: 2,
-      },
-    },
   };
 };
 harden(makeFeedPolicy);

packages/boot/test/fast-usdc/fast-usdc.test.ts

@@ -153,7 +153,7 @@ test.serial(
   },
 );
 
-test.serial('writes feed policy to vstorage', async t => {
+test.serial('writes chain policy to vstorage', async t => {
   const { storage } = t.context;
   const opts = {
     node: 'fastUsdc.feedPolicy',

packages/boot/test/fast-usdc/snapshots/fast-usdc.test.ts.md

@@ -4,7 +4,7 @@ The actual snapshot is saved in `fast-usdc.test.ts.snap`.
 
 Generated by [AVA](https://avajs.dev).
 
-## writes feed policy to vstorage
+## writes chain policy to vstorage
 
 > Under "published", the "fastUsdc.feedPolicy" node is delegated to the general and chain-specific policies for the Fast USDC feed.
 > The example below illustrates the schema of the data published there.
@@ -15,16 +15,8 @@ Generated by [AVA](https://avajs.dev).
       [
         'published.fastUsdc.feedPolicy',
         {
-          chainPolicies: {
-            Arbitrum: {
-              attenuatedCttpBridgeAddress: '0xe298b93ffB5eA1FB628e0C0D55A43aeaC268e347',
-              cctpTokenMessengerAddress: '0x19330d10D9Cc8751218eaf51E8885D058642E08A',
-              chainId: 42161,
-              confirmations: 2,
-            },
-          },
-          nobleAgoricChannelId: 'channel-21',
-          nobleDomainId: 4,
+          body: '#{"chainPolicies":{"Arbitrum":{"attenuatedCttpBridgeAddress":"0xe298b93ffB5eA1FB628e0C0D55A43aeaC268e347","blockWindowSize":10,"cctpTokenMessengerAddress":"0x19330d10D9Cc8751218eaf51E8885D058642E08A","chainId":42161,"confirmations":2,"maxAmountPerBlockWindow":"+20000000000"}},"nobleAgoricChannelId":"channel-21","nobleDomainId":4}',
+          slots: [],
         },
       ],
     ]

packages/builders/scripts/fast-usdc/init-fast-usdc.js

@@ -122,7 +122,15 @@ export default async (homeP, endowments) => {
       return configurations[net].feedPolicy;
     }
     if (!feedPolicy) throw Error(feedPolicyUsage);
-    return JSON.parse(feedPolicy);
+    const parsed = JSON.parse(feedPolicy);
+    if (!parsed.chainPolicies) {
+      // chainPolicies contain bigints which can't be stringified
+      return {
+        // @ts-expect-error spreading CopyRecord & Passable
+        ...configurations.MAINNET.feedPolicy,
+        ...parsed,
+      };
+    }
   };
 
   const parseOracleArgs = () => {

packages/fast-usdc/src/fast-usdc-policy.core.js

@@ -3,6 +3,7 @@
 import { E } from '@endo/far';
 import { fromExternalConfig } from './utils/config-marshal.js';
 import { FeedPolicyShape } from './type-guards.js';
+import { makePublishingStorageKit } from './fast-usdc.start.js';
 
 /**
  * @import {Passable} from '@endo/pass-style'
@@ -18,11 +19,13 @@ const FEED_POLICY = 'feedPolicy';
  * XXX copied from fast-usdc.start.js
  *
  * @param {ERef<StorageNode>} node
- * @param {FeedPolicy} policy
+ * @param {ERef<Marshaller>} marshaller
+ * @param {FeedPolicy & Passable} policy
  */
-const publishFeedPolicy = async (node, policy) => {
+const publishFeedPolicy = async (node, marshaller, policy) => {
   const feedPolicy = E(node).makeChildNode(FEED_POLICY);
-  await E(feedPolicy).setValue(JSON.stringify(policy));
+  const value = await E(marshaller).toCapData(policy);
+  await E(feedPolicy).setValue(JSON.stringify(value));
 };
 
 /**
@@ -32,7 +35,7 @@ const publishFeedPolicy = async (node, policy) => {
  * @param {{ options: LegibleCapData<{feedPolicy: FeedPolicy & Passable}> }} config
  */
 export const updateFastUsdcPolicy = async (
-  { consume: { agoricNames, chainStorage } },
+  { consume: { agoricNames, board, chainStorage } },
   config,
 ) => {
   /** @type {Issuer<'nat'>} */
@@ -46,9 +49,12 @@ export const updateFastUsdcPolicy = async (
     harden({ feedPolicy: FeedPolicyShape }),
   );
 
-  const storageNode = await E(chainStorage).makeChildNode(contractName);
+  const { storageNode, marshaller } = await makePublishingStorageKit(
+    contractName,
+    { board, chainStorage },
+  );
 
-  await publishFeedPolicy(storageNode, feedPolicy);
+  await publishFeedPolicy(storageNode, marshaller, feedPolicy);
 };
 
 /**
@@ -67,6 +73,7 @@ export const getManifestForUpdateFastUsdcPolicy = (_utils, { options }) => {
 
           // widely shared: name services
           agoricNames: true,
+          board: true,
         },
       },
     },

packages/fast-usdc/src/fast-usdc.start.js

@@ -22,6 +22,7 @@ import { fromExternalConfig } from './utils/config-marshal.js';
  * @import {Board} from '@agoric/vats'
  * @import {ManifestBundleRef} from '@agoric/deploy-script-support/src/externalTypes.js'
  * @import {BootstrapManifest} from '@agoric/vats/src/core/lib-boot.js'
+ * @import {Passable} from '@endo/pass-style'
  * @import {LegibleCapData} from './utils/config-marshal.js'
  * @import {FastUsdcSF} from './fast-usdc.contract.js'
  * @import {FeedPolicy, FastUSDCConfig} from './types.js'
@@ -57,7 +58,10 @@ export const FastUSDCConfigShape = M.splitRecord({
  *   board: ERef<Board>;
  * }} io
  */
-const makePublishingStorageKit = async (path, { chainStorage, board }) => {
+export const makePublishingStorageKit = async (
+  path,
+  { chainStorage, board },
+) => {
   const storageNode = await E(chainStorage).makeChildNode(path);
 
   const marshaller = await E(board).getPublishingMarshaller();
@@ -89,11 +93,13 @@ const POOL_METRICS = 'poolMetrics';
 
 /**
  * @param {ERef<StorageNode>} node
- * @param {FeedPolicy} policy
+ * @param {ERef<Marshaller>} marshaller
+ * @param {FeedPolicy & Passable} policy
  */
-const publishFeedPolicy = async (node, policy) => {
+const publishFeedPolicy = async (node, marshaller, policy) => {
   const feedPolicy = E(node).makeChildNode(FEED_POLICY);
-  await E(feedPolicy).setValue(JSON.stringify(policy));
+  const value = await E(marshaller).toCapData(policy);
+  await E(feedPolicy).setValue(JSON.stringify(value));
 };
 
 /**
@@ -211,7 +217,7 @@ export const startFastUSDC = async (
   fastUsdcKit.resolve(harden({ ...kit, privateArgs }));
   const { instance, creatorFacet } = kit;
 
-  await publishFeedPolicy(storageNode, feedPolicy);
+  await publishFeedPolicy(storageNode, marshaller, feedPolicy);
 
   const {
     issuers: fastUsdcIssuers,

packages/fast-usdc/src/type-guards.js

@@ -122,9 +122,11 @@ harden(PoolMetricsShape);
 /** @type {TypedPattern<ChainPolicy>} */
 export const ChainPolicyShape = {
   attenuatedCttpBridgeAddress: EvmHashShape,
+  blockWindowSize: M.number(),
   cctpTokenMessengerAddress: EvmHashShape,
   confirmations: M.number(),
   chainId: M.number(),
+  maxAmountPerBlockWindow: M.bigint(),
 };
 harden(ChainPolicyShape);
 

packages/fast-usdc/src/types.ts

@@ -83,12 +83,16 @@ export interface PoolMetrics extends PoolStats {
 export interface ChainPolicy {
   /** `msg.sender` of DepositAndBurn to TokenMessenger must be an attenuated wrapper contract that does not contain `replaceDepositForBurn` */
   attenuatedCttpBridgeAddress: EvmHash;
+  /** the number of blocks to consider for `maxAmountPerBlockWindow` */
+  blockWindowSize: number;
   /** @see {@link https://developers.circle.com/stablecoins/evm-smart-contracts} */
   cctpTokenMessengerAddress: EvmHash;
   /** e.g., `1` for ETH mainnet 42161 for Arbitrum One. @see {@link https://chainlist.org/} */
   chainId: EvmChainID;
   /** the number of block confirmations to observe before reporting */
   confirmations: number;
+  /** do not advance more than this amount per block window */
+  maxAmountPerBlockWindow: bigint;
 }
 
 export interface FeedPolicy {

packages/fast-usdc/src/utils/deploy-config.js

@@ -2,7 +2,7 @@ import { denomHash, withChainCapabilities } from '@agoric/orchestration';
 import fetchedChainInfo from '@agoric/orchestration/src/fetched-chain-info.js';
 
 /**
- * @import {FastUSDCConfig} from '@agoric/fast-usdc/src/types.js'
+ * @import {ChainPolicy, FastUSDCConfig} from '@agoric/fast-usdc/src/types.js'
  * @import {Passable} from '@endo/marshal';
  * @import {CosmosChainInfo, Denom, DenomDetail} from '@agoric/orchestration';
  */
@@ -37,6 +37,13 @@ export const defaultAssetInfo = [
 ];
 harden(defaultAssetInfo);
 
+/** @type {Pick<ChainPolicy, 'blockWindowSize' | 'maxAmountPerBlockWindow'>} */
+export const defaultThresholdsAndLimits = {
+  blockWindowSize: 10,
+  maxAmountPerBlockWindow: 20_000_000_000n,
+};
+harden(defaultThresholdsAndLimits);
+
 const agoricAssetInfo = defaultAssetInfo.filter(
   ([_d, i]) => i.chainName === 'agoric',
 );
@@ -70,6 +77,7 @@ export const configurations = {
             '0x19330d10D9Cc8751218eaf51E8885D058642E08A',
           chainId: 42161,
           confirmations: 2,
+          ...defaultThresholdsAndLimits,
         },
       },
     },
@@ -99,6 +107,7 @@ export const configurations = {
             '0x19330d10D9Cc8751218eaf51E8885D058642E08A',
           chainId: 42161,
           confirmations: 2,
+          ...defaultThresholdsAndLimits,
         },
       },
     },
@@ -124,6 +133,7 @@ export const configurations = {
           cctpTokenMessengerAddress: '0xTODO',
           chainId: 421614,
           confirmations: 2,
+          ...defaultThresholdsAndLimits,
         },
       },
     },
@@ -146,6 +156,7 @@ export const configurations = {
           cctpTokenMessengerAddress: '0xTODO',
           chainId: 421614,
           confirmations: 2,
+          ...defaultThresholdsAndLimits,
         },
       },
     },