clean up liveslots tests

[turadg]

refs: #5575

Description

I read #5575 (comment) and thought it would be good to be on the latest version of Ava and default configuration before reworking the tests more.

This does that and also changes the four test.failing to use test that are confirmed to be the correct behavior. Since the test is of test failures, it uses a new spy instead.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

This is one package of the monorepo on Ava 6. I tried bumping them all before but ran into problems. We should tackle them all eventually,

• upgrade Ava to v6 #9083

Testing Considerations

This might solve #5575 but we won't know for a while since it's intermittent. Still it reduces variables in solving that problem.

Upgrade Considerations

none

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	6fbb689
Status:	✅  Deploy successful!
Preview URL:	https://0480dd78.agoric-sdk.pages.dev
Branch Preview URL:	https://5575-liveslots-gc.agoric-sdk.pages.dev

View logs

[mhofman]

While I very much like switching to worker threads (if we're compatible) and the test cleanup, I'm a less convinced by the individual switch of a single package to ava@6. I'd prefer if we kept that for #9083

[turadg]

individual switch of a single package to ava@6

It is regrettable but in exploring #9081 it's going to be a while until we adopt it. Even when we can get green CI, there are some UX regressions that may require upstream contributions.

Meanwhile we have a flakey GC test, which is a more severe technical debt than packages having different versions.

[mergify]

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

[mhofman]

we have a flakey GC test, which is a more severe technical debt than packages having different versions.

Sure, I just don't understand how a new version of ava is expected to fix the flakey aspect. It seems we're shooting in the dark here, and it feels that the workerThreads change is a lot more likely to have an effect than a newer version. Unless there is something specific with newer ava that is expected to help, but I don't see anything mentioned in the description.

[turadg]

how a new version of ava is expected to fix the flakey aspect

Not expected. Just reducing variables in debugging.

I agree that workerThreads is the substantive change. I've removed the Ava 6 change.

I also went looking for more false test.failing and found one in dvo-test-harness.test.js. When I replace .failing with the spy, it's still failing. I suspect because the .failing was hiding an unexpected failure. I have to get back to other work so will leave this here for the next person who works on #5575 (currently unassigned).