New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fusdc chain policy limits #10814

Merged

mergify merged 3 commits into master from pc/chain-policy

Jan 11, 2025

Member

0xpatrickdev commented Jan 8, 2025 •

edited

Loading

closes: #10812

Description

Adds rateLimits to ChainPolicy:

rateLimits: {
  /** do not advance more than this amount for an individual transaction */
  tx: bigint;
  /** do not advance more than this amount per block window */
  blockWindow: bigint;
  /** the number of blocks to consider for `blockWindow` */
  blockWindowSize: number;
};

Renames attenuatedCttpBridgeAddress to attenuatedCttpBridgeAddresses to accept a list of attenuated bridge contracts.
Adds a fast-usdc-tool.ts script to multichain-testing to bootstrap fast-usdc and set up an environment for testing with the OCW.

Security Considerations

This is an additional line of defense for FUSDC to limit the total value flowing through the system over a window of blocks.

Scaling Considerations

None, handled in off-chain oracle operator software.

Documentation Considerations

None

Testing Considerations

Updates existing tests

Upgrade Considerations

None, targeting initial release of FUSDC.

0xpatrickdev requested a review from a team as a code owner

January 8, 2025 00:02

0xpatrickdev requested a review from AgoricTriage

January 8, 2025 00:02

cloudflare-workers-and-pages bot commented Jan 8, 2025 •

edited

Loading

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`1b1b52d`
Status:	✅ Deploy successful!
Preview URL:	https://b65725c0.agoric-sdk.pages.dev
Branch Preview URL:	https://pc-chain-policy.agoric-sdk.pages.dev

0xpatrickdev force-pushed the pc/chain-policy branch from 750eb2f to 1e30ac9 Compare

January 8, 2025 00:06

0xpatrickdev requested a review from dckc

January 8, 2025 00:13

0xpatrickdev added the force:integration label

0xpatrickdev marked this pull request as draft

January 8, 2025 23:40

dckc reviewed

View reviewed changes

Member

dckc left a comment

oops; I gotta run.
this is what I have so far...

multichain-testing/scripts/fast-usdc.ts Outdated

+                if (values.help) {
+                  console.log(`
+              Usage:

Member

dckc Jan 8, 2025

please move this Usage string constant to the top of the file.

I was going to ask for a file comment, but this is in some ways better.

The file name gave very little clue about what it's for too... though now that I see what it's for, I suppose that name is not bad. But maybe fast-usdc-tool.ts would be better.

multichain-testing/scripts/fast-usdc.ts Outdated

+                ./fast-usdc.ts fund-pool
+                ./fast-usdc.ts fund-faucet
+              `);
+                  process.exit(0);

Member

dckc Jan 8, 2025

I'd rather we don't hide use of this very powerful process.exit authority under the name parseCommandLine(). Return undefined or throw or something instead, please?

multichain-testing/scripts/fast-usdc.ts Outdated

+              };
+              const main = async () => {
+                const { command, mnemonic, oracles, provisionOracles } = parseCommandLine();

Member

dckc Jan 8, 2025

Suggested change

      
              const { command, mnemonic, oracles, provisionOracles } = parseCommandLine();
          
              const job = parseCommandLine();
          
              if (!job) return;
          
              const { command, mnemonic, oracles, provisionOracles } = job;

multichain-testing/scripts/fast-usdc.ts Outdated

+                    );
+                  }
+                },
+              } as unknown as ExecutionContext;

Member

dckc Jan 8, 2025

would this suffice?

Suggested change

      
            } as unknown as ExecutionContext;
          
            } as Pick<ExecutionContext, 'log' | 'is'>;

multichain-testing/scripts/fast-usdc.ts Outdated

+                const assertProvisioned = async address => {
+                  try {
+                    await vstorageClient.queryData(`published.wallet.${address}.current`);
+                    return true;

Member

dckc Jan 8, 2025

Suggested change

      
                  return true;
          
                  return;

packages/boot/test/fast-usdc/snapshots/fast-usdc.test.ts.md Outdated

-                        },
-                        nobleAgoricChannelId: 'channel-21',
-                        nobleDomainId: 4,
+                        body: '#{"chainPolicies":{"Arbitrum":{"attenuatedCttpBridgeAddress":"0xe298b93ffB5eA1FB628e0C0D55A43aeaC268e347","blockWindowSize":10,"cctpTokenMessengerAddress":"0x19330d10D9Cc8751218eaf51E8885D058642E08A","chainId":42161,"confirmations":2,"maxAmountPerBlockWindow":"+20000000000"}},"nobleAgoricChannelId":"channel-21","nobleDomainId":4}',

Member

dckc Jan 8, 2025

the function for documenting vstorage supports rendering this nicely. There's a show function or something.

packages/builders/scripts/fast-usdc/init-fast-usdc.js Outdated

-                  return JSON.parse(feedPolicy);
+                  const parsed = JSON.parse(feedPolicy);
+                  if (!parsed.chainPolicies) {
+                    // chainPolicies contain bigints which can't be stringified

Member

dckc Jan 8, 2025

this should use LegibleCapData then, I think

Member

dckc Jan 10, 2025

oic... this is saying "if the CLI arg doesn't have chainPolicies, fill it in from MAINNET"
maybe that's good enough

packages/fast-usdc/src/fast-usdc-policy.core.js Outdated

                */
-              const publishFeedPolicy = async (node, policy) => {
+              const publishFeedPolicy = async (node, marshaller, policy) => {

Member

dckc Jan 8, 2025

can policy have remotables in it? if not, you can use a data-only marshaller that's local to this function.

packages/fast-usdc/src/fast-usdc-policy.core.js Outdated

@@ @@ -32,7 +35,7 @@ const publishFeedPolicy = async (node, policy) => { @@
                * @param {{ options: LegibleCapData<{feedPolicy: FeedPolicy & Passable}> }} config
                */
               export const updateFastUsdcPolicy = async (
-                { consume: { agoricNames, chainStorage } },
+                { consume: { agoricNames, board, chainStorage } },

Member

dckc Jan 8, 2025

The board marshaller looks like overkill.

packages/fast-usdc/src/fast-usdc.start.js Outdated

                */
-              const publishFeedPolicy = async (node, policy) => {
+              const publishFeedPolicy = async (node, marshaller, policy) => {

Member

dckc Jan 8, 2025

again, I don't think the marshaller needs to be passed in

0xpatrickdev force-pushed the pc/chain-policy branch 2 times, most recently from 6555348 to 378f571 Compare

January 9, 2025 01:05

0xpatrickdev commented

View reviewed changes

multichain-testing/scripts/fast-usdc-tool.ts Outdated Show resolved Hide resolved

dckc reviewed

View reviewed changes

packages/boot/test/fast-usdc/snapshots/fast-usdc.test.ts.md Outdated

+                            cctpTokenMessengerAddress: '0x1682Ae6375C4E4A97e4B583BC394c861A46D8962',
+                            chainId: 8453,
+                            confirmations: 2,
+                            maxAmountPerBlockWindow: 20000000000n,

Member

dckc Jan 10, 2025

to get this to show up next to blockWindowSize, maybe...

Suggested change

      
                          maxAmountPerBlockWindow: 20000000000n,
          
                          blockWindowMaxAmount: 20000000000n,

dckc reviewed

View reviewed changes

multichain-testing/scripts/fast-usdc-tool.ts Outdated

    
                };

                const start = async () => {

                  if (!chainInfo.noble) {

Member

dckc Jan 10, 2025

It looks like the env stuff is gone (yay!), but I still can't see how chainInfo.noble is anything but a design-time constant.

0xpatrickdev force-pushed the pc/chain-policy branch 2 times, most recently from 7088f49 to 3ec61df Compare

January 10, 2025 22:47

0xpatrickdev marked this pull request as ready for review

January 10, 2025 22:47

0xpatrickdev commented

View reviewed changes

Member Author

0xpatrickdev left a comment •

edited

Loading

Thanks for the feedback @dckc . I think all comments are addressed, thanks for spending time to walk me through the data only marshaller.

0xpatrickdev requested a review from dckc

January 10, 2025 22:48

dckc approved these changes

View reviewed changes

Member

dckc left a comment

👍

0xpatrickdev added 3 commits

January 10, 2025 18:32


          tools: fast-usdc bootstrap script

cb2ca72

utility script to assist with local development. includes:
- start contract with optional --oracles
- fund agoric faucet with USDC from remote chain
- fund Liquidity Pool for USDC
- provision smart wallet (using --mnemonic)


          chore: chain policy rate limits

246919e


          chore: attenuatedCttpBridgeAddress -> attenuatedCttpBridgeAddresses

1b1b52d

- ensure `ChainPolicy` can support multiple bridge attenuation contracts

0xpatrickdev force-pushed the pc/chain-policy branch from 3ec61df to 1b1b52d Compare

January 10, 2025 23:32

0xpatrickdev added the automerge:rebase label

0xpatrickdev mentioned this pull request

limits and tiered confirmations in ChainPolicy #10812

Closed

mergify bot merged commit b58d523 into master

87 of 96 checks passed

mergify bot deleted the pc/chain-policy branch

January 11, 2025 00:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge:rebase force:integration