fix wallet extract-id CLI #10892
Merged
fix wallet extract-id CLI #10892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Jan 24, 2025
| @@ -132,6 +133,7 @@ harden(execSwingsetTransaction); | |||
| /** | |||
| * | |||
| * @param {MinimalNetworkConfig} net | |||
| * @returns {ParamsSDKType} | |||
There was a problem hiding this comment.
I'm not sure JSON output from agd always directly corresponds with protobuf stuff. I wouldn't be surprised if it does in this case, but did you happen to verify experimentally? Or maybe there's a caller that clearly relies on it?
turadg
added
automerge:rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10891
Description
A recent refactor of agoric-cli introduced an error. It wasn't caught by typecheck because the callsite was
any.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
This PR doesn't have a runtime regression test because this is a very uncommon code path which does have some CI coverage in a3p-integration (1d01880)
Upgrade Considerations
Not run on chain.