Solve different smells in the code. #356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 19, 2024 22:11
…om source.JdbcSourceTask.start mehtod
…DefinitionFor is at a wrong place, it should be there in TableDefinitions file
… Moved method from DbStrucutre.java to TableDefinitions.java
…extract 2 more class BufferManager and TableNameGenerator
…ig, the methods are validateDeleteEnabled, validatePKModeAgainstPKFields
JASH-PATEL-6566
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decompose the conditions -
source.JdbcSourceTask.javaRename variable -
source.JdbcSourceTask.java(atLeastOneTimestampNotOptional to timestampRequired)Extract methods -
source.JdbcSourceTask.java(start()method is so long so I extract the methods from this and try to makestart()method small. Extracted methods:validateConfig(),initializeDialect(),processQueryMode(),getTablePartitionsToCheck(),processOffsets(),addTableQuerier())Move method -
sink.Dbstructure.java(DbStructureclass in not a proper place fortableDefinitionFor()so I moved it intoTableDefinitionsclass)Extract Class -
sink.JdbcDbWriter(Decompose theJdbcDbWriterinto 2 classes:BufferManagerandTableNameGenerator)Pull-up method -
sink.JdbcSinkConfig.java(pull-up method means move method from sub class to parent class, so I movedvalidateDeleteEnabled()andvalidatePKModeAgainstPKFields()into parent class which isJdbcConfig)