Code

Solve different smells in the code.#356

Code

Open

JASH-PATEL-6566 wants to merge 8 commits intoAiven-Open:masterAiven-Open/jdbc-connector-for-apache-kafka:masterfrom JASH-PATEL-6566:masterJASH-PATEL-6566/jdbc-connector-for-apache-kafka:masterCopy head branch name to clipboard

+415-308

Commits

Commits on Nov 20, 2024

• solve-smells: Solve implementation smells in JdbcSourceTask.java

  

  JASH-PATEL-6566

  committed
  ef51da2

Commits on Nov 28, 2024

• Refactor: Solve Complex Condition by devide conditions into smaller parts

  

  JASH-PATEL-6566

  committed
  55bc771

• improve: decompose condition and also change the conditions in main logic

  

  JASH-PATEL-6566

  committed
  fd1c679

• resolve-smells: resolve Implementation smell by extracting methods from source.JdbcSourceTask.start mehtod

  

  JASH-PATEL-6566

  committed
  75e4239

Commits on Nov 29, 2024

• Solve-Smell: There is a feature envy smell in DbStructure file, tableDefinitionFor is at a wrong place, it should be there in TableDefinitions file

  

  JASH-PATEL-6566

  committed
  0540c7c

• Solve-Smell: solve feature envy with move method in DbStrucutre.java, Moved method from DbStrucutre.java to TableDefinitions.java

  

  JASH-PATEL-6566

  committed
  e9f306c

• Solve-Smell: solve Insufficient Modularization for JdbcWriter class, extract 2 more class

  Show description for 0a308a7
  

  JASH-PATEL-6566

  committed
  0a308a7

Commits on Nov 30, 2024

• Solve-Smell: just pull-out the method from JdbcSinkConfig to JdbcConfig, the methods are validateDeleteEnabled, validatePKModeAgainstPKFields

  

  JASH-PATEL-6566

  committed
  f7ed7ac