Created_footer_and_header #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add header and footer components, need to add logo and other materials in both. Co-Authored-By: Anosh Malik <[email protected]> Co-Authored-By: Roman-Hal <[email protected]> Co-Authored-By: Yousef Shaikhan <[email protected]>
AnoshMalik
reviewed
Apr 23, 2023
client/src/pages/Home.js
Outdated
| @@ -2,43 +2,53 @@ import { useEffect, useState } from "react"; | |||
| import { Link } from "react-router-dom"; | |||
AnoshMalik
reviewed
Apr 23, 2023
client/src/Components/Footer.js
Outdated
| @@ -0,0 +1,9 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Use double quotes around 'react' please
AnoshMalik
requested changes
Apr 23, 2023
Roman-Hal
reviewed
Apr 23, 2023
client/src/pages/Home.js
Outdated
| @@ -2,43 +2,53 @@ import { useEffect, useState } from "react"; | |||
| import { Link } from "react-router-dom"; | |||
There was a problem hiding this comment.
Maybe to comment out this lines would avoid the conflict.
Roman-Hal
reviewed
Apr 23, 2023
| @@ -2,43 +2,53 @@ import { useEffect, useState } from "react"; | |||
| import { Link } from "react-router-dom"; | |||
|
|
|||
There was a problem hiding this comment.
Commenting out the line might help to avoid the conflict.
Roman-Hal
requested changes
Apr 23, 2023
youweb3
reviewed
Apr 23, 2023
|
|
||
| export function Home() { | ||
| const [message, setMessage] = useState("Loading..."); |
Double quotation added in footer and header imports commented unnecessary codes Co-Authored-By: Anosh Malik <[email protected]> Co-Authored-By: Roman-Hal <[email protected]> Co-Authored-By: Yousef Shaikhan <[email protected]>
Co-Authored-By: Anosh Malik <[email protected]> Co-Authored-By: Roman-Hal <[email protected]> Co-Authored-By: Yousef Shaikhan <[email protected]>
youweb3
approved these changes
Apr 23, 2023
| <h1>Suggestion Generator</h1> | ||
| <Footer /> | ||
| </div> | ||
| ); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6 -Created_footer_and_header by Azadeh
Checklist: