Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created_footer_and_header #15

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions client/src/Components/Footer.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import React from "react";

const Footer = () => {
return (
<div>Footer</div>
);
};

export default Footer;
9 changes: 9 additions & 0 deletions client/src/Components/Header.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import React from "react";

const Header = () => {
return (
<div><button>About</button></div>
);
};

export default Header;
75 changes: 42 additions & 33 deletions client/src/pages/Home.js
Original file line number Diff line number Diff line change
@@ -1,43 +1,52 @@
import { useEffect, useState } from "react";
import { Link } from "react-router-dom";
// import { useEffect, useState } from "react";
// import { Link } from "react-router-dom";

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out the line might help to avoid the conflict.

import "./Home.css";
import logo from "./logo.svg";
import Header from "../Components/Header";
import Footer from "../Components/Footer";
// import logo from "./logo.svg";

export function Home() {
const [message, setMessage] = useState("Loading...");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid this line

// const [message, setMessage] = useState("Loading...");

useEffect(() => {
fetch("/api")
.then((res) => {
if (!res.ok) {
throw new Error(res.statusText);
}
return res.json();
})
.then((body) => {
setMessage(body.message);
})
.catch((err) => {
console.error(err);
});
}, []);
// useEffect(() => {
// fetch("/api")
// .then((res) => {
// if (!res.ok) {
// throw new Error(res.statusText);
// }
// return res.json();
// })
// .then((body) => {
// setMessage(body.message);
// })
// .catch((err) => {
// console.error(err);
// });
// }, []);

// return (
// <main role="main">
// <div>
// <img
// className="logo"
// data-qa="logo"
// src={logo}
// alt="Just the React logo"
// />
// <h1 className="message" data-qa="message">
// {message}
// </h1>
// <Link to="/about/this/site">About</Link>
// </div>
// </main>
// );
return (
<main role="main">
<div>
<img
className="logo"
data-qa="logo"
src={logo}
alt="Just the React logo"
/>
<h1 className="message" data-qa="message">
{message}
</h1>
<Link to="/about/this/site">About</Link>
</div>
</main>
<div>
<Header />
<h1>Suggestion Generator</h1>
<Footer />
</div>
);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add semicolon in line 51


Expand Down