feat(load): add arrow endpoints #2200
Conversation
…om/AntaresSimulatorTeam/AntaREST into feat/add-load-endpoints-with-arrow
…ow' into feat/add-load-endpoints-with-arrow
| @@ -365,6 +366,7 @@ def __init__( | |||
| self.adequacy_patch_manager = AdequacyPatchManager(self.storage_service) | |||
| self.advanced_parameters_manager = AdvancedParamsManager(self.storage_service) | |||
| self.hydro_manager = HydroManager(self.storage_service) | |||
| self.load_manager = LoadManager(self.storage_service) | |||
There was a problem hiding this comment.
Generally speaking for the other matrices, what is your vision here ? For hydro for instance, we want to add the code inside the HydroManager or do we want to create a specific manager on the side ? I personally prefer the 1st option
…ow' into feat/add-load-endpoints-with-arrow # Conflicts: # antarest/study/business/load_management.py
| def __init__(self, storage_service: StudyStorageService) -> None: | ||
| self.storage_service = storage_service | ||
|
|
||
| def get_load_matrix(self, study: Study, area_id: str) -> Response: |
There was a problem hiding this comment.
This "business" layer should be independent from web considerations, it should return a dataframe instead.
Formatting to arrow should be done in the web layer.
| tags=[APITag.study_data], | ||
| summary="Update load series data", | ||
| ) | ||
| def update_load_series( |
There was a problem hiding this comment.
If we want to support arrow input, I don't think we will be able to use a pydantic model (LoadDTO), because they expect JSON, which cannot contain binary data.
So: if we want the same URL to support at the same time JSON and arrow, we will need to separate it in 2 functions I think, for example discriminated by the "accept-content" header.
In any case, I think the function which will accept arrow input will need to have something else than a pydantic model as its argument (bytes or something else, I did not look into fastapi support for binary input).
There was a problem hiding this comment.
Eventually, we decided to only support Arrow format. I'll check to see what is best to handle binary inputs
…s-with-arrow # Conflicts: # antarest/study/service.py # antarest/study/web/study_data_blueprint.py
No description provided.